Obsidian_to_Anki icon indicating copy to clipboard operation
Obsidian_to_Anki copied to clipboard

Published 20 hours ago • verified publisher icon ObsidianToAnki

Upstream obisidian sample plugin removed rollupjs and started using ESBuild

Open ShootingKing-AM opened this issue 1 year ago • 3 comments

  • have to use recommended build mode, may break in future - Starting from https://github.com/obsidianmd/obsidian-sample-plugin/commit/3afc9d78ab809784d8ccf6d17e94c1509330e217

  • Also relates to https://github.com/Pseudonium/Obsidian_to_Anki/pull/366

ShootingKing-AM avatar Jan 19 '24 16:01 ShootingKing-AM

Just my 2 cents. I don't see a reason to change the build tool just because the sample plugin opted for a different tool.

All build tools are different way of doing the same thing. So the choice of tool is an opinion. There is no reason to believe this change in the sample plugin could result in a breaking change.

mattcoleanderson avatar Feb 02 '24 09:02 mattcoleanderson

I am not an expert on the matter but I don't think it costs us anything to follow the obsidian developer's recommendation.

ShootingKing-AM avatar Feb 02 '24 13:02 ShootingKing-AM

Just my thoughts. It will cost something. It will cost time and effort to implement and learn a new build tool. In my opinion, their choice to change isn't really a recommendation so much as an opinionated choice by the developer who made the commit. It's highly likely they just prefer esbuild because they are familiar with it. But there really is no benefit between the two.

That said, if you prefer esbuild, then by all means change it. But I believe it's preference not necessity.

mattcoleanderson avatar Feb 02 '24 15:02 mattcoleanderson