Obsidian_to_Anki icon indicating copy to clipboard operation
Obsidian_to_Anki copied to clipboard

fixed addition of Obsidian tags in regex notes

Open st3v3nmw opened this issue 3 years ago • 9 comments

This should fix #196 where Obsidian tags in regex notes aren't added to Anki.

st3v3nmw avatar Mar 12 '21 11:03 st3v3nmw

Is this included in the current version? @st3v3nmw . If not, how can I manually fix it? I checked the code, it seems to be the same. But my tags aren't getting picked

dummifiedme avatar May 29 '21 16:05 dummifiedme

It's not currently included. To manually fix it, clone my fork of this repository, install NodeJS, and run npm i inside the folder. Then run npm run dev to compile main.ts to main.js. Then replace the main.js file in the plugin's folder in .obsidian/plugins.

st3v3nmw avatar May 29 '21 19:05 st3v3nmw

To manually fix it, clone my fork of this repository, install NodeJS, and run npm i inside the folder.

npm WARN tarball tarball data for obsidian@https://github.com/obsidianmd/obsidian-api/tarball/master (sha512-OGZPxkzYJ1Lgjd4f7eaBFr8KqIG8vkwVcOblH5BMSIoMieY1NmXL9/ouVwMjc1NJH7ZN6Zi7Qclz8Y42fd8rwQ==) seems to be corrupted. Trying one more time.
npm ERR! code EINTEGRITY
npm ERR! sha512-OGZPxkzYJ1Lgjd4f7eaBFr8KqIG8vkwVcOblH5BMSIoMieY1NmXL9/ouVwMjc1NJH7ZN6Zi7Qclz8Y42fd8rwQ== integrity checksum failed when using sha512: wanted sha512-OGZPxkzYJ1Lgjd4f7eaBFr8KqIG8vkwVcOblH5BMSIoMieY1NmXL9/ouVwMjc1NJH7ZN6Zi7Qclz8Y42fd8rwQ== but got sha512-09/Zpb7sXE264OLk3DDbieU895d6NaNIIL8eyKR+5WpXPSYKeDfwy4yQh3WSb6KHWTJpbyvqUDchh8Yy4lHiRQ==. (15583 bytes)

Also, will I lose the settings of the plugin if I make a complete change in the plugin folder?

Can't I just fix the part where you have modified the code?

From comparison, I could see 2 places where there were a semicolon and has been removed in the new code...

dummifiedme avatar May 30 '21 05:05 dummifiedme

Try deleting the package-lock.json file and try again.

Also, will I lose the settings of the plugin if I make a complete change in the plugin folder?

No. You'll only change the main.js file. The settings are stored in data.json.

Also, I've made a release on my fork that you can easily download and use.

st3v3nmw avatar May 31 '21 05:05 st3v3nmw

Thanks!! :)

On Mon, 31 May 2021 at 10:52, Stephen Mwangi @.***> wrote:

Try deleting the package-lock.json file and try again.

Also, will I lose the settings of the plugin if I make a complete change in the plugin folder?

No. You'll only change the main.js file. The settings are stored in data.json.

Also, I've made a release on my fork that you can easily download and use.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Pseudonium/Obsidian_to_Anki/pull/230#issuecomment-851184467, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQMZMQMQOTUS5GU4AJKUNKDTQMMKHANCNFSM4ZCDEUVQ .

dummifiedme avatar May 31 '21 06:05 dummifiedme

bump - would really love this functionality!

rjbergerud avatar Sep 19 '21 19:09 rjbergerud

Why is this not being merged? Just made a similar pull request (https://github.com/Pseudonium/Obsidian_to_Anki/pull/287) that does not include changes to gitignore or the lockfile, if that's the problem. I closed my pull request because I found out about this one.

ludvigalden avatar Oct 17 '21 10:10 ludvigalden

Why is this not being merged? Just made a similar pull request (#287) that does not include changes to gitignore or the lockfile, if that's the problem. I closed my pull request because I found out about this one.

Because the developer is away since the last release :)

dummifiedme avatar Oct 19 '21 05:10 dummifiedme

Thanks @st3v3nmw ! This has been most frustrating up until now. Much appreciated. I cloned your fork but hopefully it will be merged soon.

timjden avatar Nov 01 '21 08:11 timjden

It's not currently included. To manually fix it, clone my fork of this repository, install NodeJS, and run npm i inside the folder. Then run npm run dev to compile main.ts to main.js. Then replace the main.js file in the plugin's folder in .obsidian/plugins.

I replaced with the one you released. It seems not working..

ghost avatar May 30 '23 12:05 ghost

@Pseudonium - is this something that is goint to be implemented soon?

lsolesen avatar Jul 28 '23 09:07 lsolesen

E2E tests for this fix are done in #479

Though its late, Thanks for the bugfix !

ShootingKing-AM avatar Jan 07 '24 11:01 ShootingKing-AM