ObserverOfTime
ObserverOfTime
~~Windows and macOS builds fail when `TREE_SITTER_REUSE_ALLOCATOR` is set. Maybe we need `TS_PUBLIC` again? :thinking:~~ Nevermind, I think the parsers are just outdated.
> I think we do. If distro packages need their own flags, they will write their own build scripts The required flags will still be the same.
> Out of interest (and for the sake of documentation): what flags are used by default (esp. `-O`)? The release build uses `-O2` and the debug build uses `-O0`. `CFLAGS`...
``` /home/runner/work/tree-sitter/tree-sitter/test/fixtures/grammars/bash/src/scanner.c:113:9: runtime error: null pointer passed as argument 2, which is declared to never be null ``` Adding `assert(heredoc->delimiter.contents != NULL);` before that line should silence UBSAN. @amaanq
> Would be good to document that somewhere, as a reference. I think the default flags are too complicated to document and not _that_ important. We can always point here...
I've added the fix to #3284.
Looks like this actually segfaults if the compiled parser is older. I can make it check the ABI version and only work on 15.
(Should not be merged before ABI 15 is a thing.)
Yes, a PR would be welcome.
That would be a bodge.