charon icon indicating copy to clipboard operation
charon copied to clipboard

`core_validatorapi_vc_user_agent` does not report end user readable VC types and versions

Open KaloyanTanev opened this issue 6 months ago • 6 comments

🎯 Problem to be solved

The metric that we push to prometheus core_validatorapi_vc_user_agent does not always send readable VC type/version. For Lighthouse it doesn't even send one.

i.e.: okhttp/4.12.0 is for Teku. While we know okhttp is a Java HTTP library and we know only Teku uses Java from our stack, it's not intuitive for users. Similar to Go-http-client/1.1 and Prysm.

🛠️ Proposed solution

Ask VCs to include the correct header.

  • [x] Lodestar
  • [ ] Lighthouse Issue: https://github.com/sigp/lighthouse/issues/7963 PR: https://github.com/sigp/lighthouse/pull/7990
  • [x] Teku Issue: https://github.com/Consensys/teku/issues/9602 PR: https://github.com/Consensys/teku/pull/9935
  • [ ] Nimbus Issue: https://github.com/status-im/nimbus-eth2/issues/7427 PR:
  • [x] Prysm Issue: https://github.com/OffchainLabs/prysm/issues/15435 PR: https://github.com/OffchainLabs/prysm/pull/15574
  • [x] Vouch

🧪 Tests

Check for all VCs (including the newly supported - Vouch) if they are properly displayed in the Validator Client Version in Grafana. Easy to test using Kurtosis.

KaloyanTanev avatar Jun 11 '25 11:06 KaloyanTanev

I think the proper way to solve this is to ask clients to report proper User-Agent. Hope that's doable. I submitted a request with Teku and asked to change the behavior: https://github.com/Consensys/teku/issues/9602

pinebit avatar Jun 25 '25 07:06 pinebit

Request for Prysm: https://github.com/OffchainLabs/prysm/issues/15435

pinebit avatar Jun 25 '25 07:06 pinebit

Should be done on client teams side.

KaloyanTanev avatar Aug 04 '25 09:08 KaloyanTanev

Prysm is fixed

KaloyanTanev avatar Aug 29 '25 09:08 KaloyanTanev

I've opened an issue for Nimbus as well: https://github.com/status-im/nimbus-eth2/issues/7427

KaloyanTanev avatar Aug 29 '25 09:08 KaloyanTanev

Opened for Lighthouse: https://github.com/sigp/lighthouse/issues/7963

KaloyanTanev avatar Aug 29 '25 10:08 KaloyanTanev