charon icon indicating copy to clipboard operation
charon copied to clipboard

core/validatorapi: check proposal data against consensus one

Open gsora opened this issue 1 year ago • 3 comments

Instead of blindly accepting VC proposal data, check it for integrity against what we have in DutyDB: if they differ, stop the process.

category: refactor ticket: none

gsora avatar Sep 18 '24 14:09 gsora

Codecov Report

Attention: Patch coverage is 53.77358% with 49 lines in your changes missing coverage. Please review.

Project coverage is 57.70%. Comparing base (c835711) to head (b5ef635). Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
core/validatorapi/validatorapi.go 52.42% 39 Missing and 10 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3292      +/-   ##
==========================================
+ Coverage   57.63%   57.70%   +0.06%     
==========================================
  Files         211      211              
  Lines       30480    30718     +238     
==========================================
+ Hits        17568    17726     +158     
- Misses      11016    11077      +61     
- Partials     1896     1915      +19     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 18 '24 14:09 codecov[bot]

Tested in kurtosis, seems to be working well.

gsora avatar Sep 23 '24 10:09 gsora