charon core/parsigdb: improve key uniqueness

Instead of only having (duty, pubkey) as parsigdb key, also use core.ParSignedDataSet.Root() to increase uniqueness factor.

This effectively eliminates the possibility that peers in the network could share duty data for a given slot and validator that doesn't match what was previously decided during consensus.

category: refactor ticket: none

Sep 12 '24 15:09 gsora

Codecov Report

Attention: Patch coverage is 60.29412% with 54 lines in your changes missing coverage. Please review.

Project coverage is 57.65%. Comparing base (768b0b3) to head (5011e64). Report is 46 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/exit_sign.go	59.77%	27 Missing and 8 partials :warning:
core/tracker/tracker.go	30.00%	13 Missing and 1 partial :warning:
core/parsigdb/memory.go	82.35%	2 Missing and 1 partial :warning:
cmd/exit.go	0.00%	2 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3283      +/-   ##
==========================================
- Coverage   57.66%   57.65%   -0.02%     
==========================================
  Files         211      211              
  Lines       30396    30516     +120     
==========================================
+ Hits        17528    17594      +66     
- Misses      10980    11025      +45     
- Partials     1888     1897       +9

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.