charon-distributed-validator-node icon indicating copy to clipboard operation
charon-distributed-validator-node copied to clipboard

Remove run.sh entrypoint for Prometheus

Open reversesigh opened this issue 10 months ago • 1 comments

When running multiple DVnodes, it can be easy to integrate them into a single prometheus job like this:

  - job_name: charon
    static_configs:
      - targets: [charon:20120,charon:20220]
    static_configs:
      - targets: [lodestar:20164,lodestar:20264]
  - job_name: lodestar

However with the entrypoint for run.sh, these changes get overwritten whenever the container relaunches. Lido already has this removed from their fork by default - and I think it makes sense to make it easier to make adjustments to prometheus.yml by default.

reversesigh avatar Jan 31 '25 12:01 reversesigh

@reversesigh This repo mainly deploys and monitors a single node. For multiple-node deployment, there is another repo where we don't use the Prometheus run script.

Also, this script centralizes all the config in a single .env file without manually editing the Prometheus yaml file to add the monitoring token and endpoint. We are open to changing the deployment while the goals above remain intact.

aly-obol avatar Feb 03 '25 19:02 aly-obol

Hi @reversesigh! I suppose you are running multiple DV nodes for different cluster on the same machine? If so, we are in the work of creating multi cluster setup, under the branch kalo/multi-cluster-setup. Feel free to get inspired by the work there if you want to have custom setup until we merge it to main. We would like to keep what there currently is for the general public though.

KaloyanTanev avatar Aug 06 '25 13:08 KaloyanTanev