charon-distributed-validator-cluster icon indicating copy to clipboard operation
charon-distributed-validator-cluster copied to clipboard

Add Nimbus version as an environment variable

Open EridianAlpha opened this issue 2 years ago • 2 comments

EridianAlpha avatar Mar 23 '23 18:03 EridianAlpha

How about we set latest? Seems like a safe fallback to have

On Thu, Mar 23, 2023 at 9:27 PM Eridian @.***> wrote:

@.**** commented on this pull request.

In nimbus/Dockerfile https://github.com/ObolNetwork/charon-distributed-validator-cluster/pull/116#discussion_r1146881499 :

@@ -1,6 +1,8 @@ -FROM statusim/nimbus-eth2:multiarch-v23.3.1 as nimbusbn +ARG NIMBUS_VERSION

Yes this can have a default set, and it will be overwritten with anything that's passed through. Does this add to a maintenance overhead/ cause duplication though, as a default value is already being set in the docker-compose.yml file on line 199?

— Reply to this email directly, view it on GitHub https://github.com/ObolNetwork/charon-distributed-validator-cluster/pull/116#discussion_r1146881499, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGAHDAEQEMEFAGRZSBWQKDW5S55BANCNFSM6AAAAAAWFTJNII . You are receiving this because you commented.Message ID: <ObolNetwork/charon-distributed-validator-cluster/pull/116/review/1355676213 @github.com>

-- Oisín Kyne

OisinKyne avatar Mar 23 '23 21:03 OisinKyne

@OisinKyne I've added "latest" and confirmed that it works.

EridianAlpha avatar Mar 23 '23 21:03 EridianAlpha