stm32-cmake
stm32-cmake copied to clipboard
ObKo
Cmake module to find STM32 Discovery library files
I think that I'm missing something, but what is the difference with whats its done in https://github.com/ObKo/stm32-cmake/blob/master/cmake/FindSTM32BSP.cmake ?
I am not sure why STM does it but there is this firmware package for the discovery that shares some similarities with the BSP sources but then then for instance the l3gd20 sources are no longer discovery specific. You can probably achieve the same thing using the BSP sources but there is a specific discovery firmware package that this module is targeted towards.
A good example is the ioe sources that don't actually exist in the BSP sources. They can be found in varying forms in the STD Peripherals library but then it becomes messy pulling sources from BSP and STD instead of just using the single firmware package from STM.
Do you know if there are other discovery packages that could need this ? If so we should support most of them or at least add an issue to remember to do it. Would it be possible for you to add a documentation of this new feature and/or an example of how to use it ? And maybe even some comments in the code even if there is almost no comment in original repo ? And maybe my understanding is incorrect but couldn't the feature benefit of a variable like for the cubes (STM32_CUBE_F4_PATH) ?
I recognize I'm not a Cmake guru so please take my remarks as a challenge to get best of the code and an easily maintainable repository.
I found this repository (alongside with other -discovery repositories) It seems that repository is more up to date that the version from website you use. Note also it's quite new repo and I suppose ST is migrating all FW to github but this is not finished for every boards now. I opened a related issue on their repo to ask about version divergence.
I would be better to wait for more information before merging this.