OpenDataStandards icon indicating copy to clipboard operation
OpenDataStandards copied to clipboard

Add CONTRIBUTING guidelines and Code Quality checks

Open mtazzari opened this issue 3 years ago • 1 comments

Following what we have done in the OasisLMF/OasisLMF repo, this PR:

  • applies PEP8 to all the codebase;
  • fixes some flake8 errors throughout the codebase (see the code-quality.yml file for more details)
  • adds OasisLMF Contributing guidelines;
  • adds a Pull Request template message reminding the user opening the PR to check the contributing guidelines;
  • introduces automatic Code Quality workflow that checks that the Python code format is PEP8 compliant that some flake8 errors are fixed.

This PR Fixes #94

mtazzari avatar Dec 05 '22 22:12 mtazzari

Ready for review.

mtazzari avatar Dec 05 '22 22:12 mtazzari

Waiting for #89 to be merged to avoid complicated conflicts. Once #89 is merged, resume this, fix conflicts and merge.

mtazzari avatar Dec 12 '22 15:12 mtazzari

Closing this because there're too many conflicts. I forked off develop and opened a new, cleaner, PR #111

mtazzari avatar Dec 20 '22 10:12 mtazzari