Use full primary key for oxstates set tables (and potentially others …

[BernhardScheffold]

…with a composite primary key)

[Sieg]

Hey @BernhardScheffold, thanks for the improvement! This looks interesting, but something like this cannot go without any tests.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[SvenBrunk]

Code Review Agent Run Status

• AI Based Review: Successful

Code Review Overview

• Summary: The PR introduces enhancements to use full primary keys for table joins in the Shop model, addressing potential issues with composite primary keys. It also includes significant changes to the DbMetaDataHandler class, adding functionality to dynamically determine table definitions and primary key details. These changes aim to improve the application's robustness and maintainability by ensuring that database operations are more accurate and efficient.
• Code change type: Feature Addition, Performance Improvement, Refactoring
• Unit tests added: False
• Estimated effort to review (1-5, lower is better): 2, due to the complexity introduced by dynamic primary key handling and the potential for unforeseen side effects in database operations.

>>See detailed code suggestions<<
The Bito AI Code Review Agent successfully reviewed 2 files and discovered 11 issues. Please review these issues along with suggested fixes in the Changed Files.

High-level Feedback

General feedback for improvement includes ensuring comprehensive testing around the new database handling functionalities, especially considering the dynamic nature of primary key usage. Additionally, while the effort to abstract database schema details is commendable, it's crucial to maintain clarity and simplicity in the implementation to avoid introducing maintenance challenges.

[Sieg]

Hey @BernhardScheffold, is there any related bugtrack item for this case? Please feel free to reopen the PR if this change makes real difference, then we should invest in this topic and implement those keys handling with priority.

Also, consider adding more information on cases that trigger problems without this change.