oxideshop_ce icon indicating copy to clipboard operation
oxideshop_ce copied to clipboard

Improve developer project setup workflow

Open fpesch opened this issue 4 years ago • 2 comments

  • Automatically creates copy of config.inc if it doesn't exist yet
  • Asks for parameters if no value was given instead of throwing an error directly (user friendliness)

fpesch avatar Aug 13 '20 21:08 fpesch

Hi,

i like the idea of copying the config.inc. But for the prompt, we would then like to have also an --no-interaction paramter, used for automatic deployments which this command should be capable of. And if we are adding the prompt, an automatic deployment could get stuck, but we want it to fail.

Also we need to have some tests regarding this. I will discuss this in team.

AlfonsMartin avatar Aug 27 '20 07:08 AlfonsMartin

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar May 07 '21 07:05 CLAassistant

Hey guys, thanks for your patience with this one. We had several discussions internally regarding the "user friendly" and "magic" topics, that are happening without people knowing about, so at the end, the decisions were:

  • lets not add this interaction, as it gives no real benefit - after showing the error of parameter missing, you will recall the previous command again and add the missing parameters. There are no parameters required in the middle of the process, everything is configured at the beginning. Adding the interaction means - later supporting something that is not really needed at all.
  • regarding making the copy of the dist config file, we decided to not do it right now, as the config file will get some love soon, and this improvement will be there as well, IF we will still need to create it as it is now.

Sieg avatar Aug 29 '23 11:08 Sieg

Also looks like the config.inc.php is copied during the first composer update run, thats another point against adding additional checks and copiyng.

Sieg avatar Oct 26 '23 15:10 Sieg