wstg icon indicating copy to clipboard operation
wstg copied to clipboard

Published 20 hours ago • verified publisher icon OWASP

Json and Markdown checklist name restructure

Open rejahrehim opened this issue 2 years ago • 6 comments

This PR covers build file restructure

  • [x] This PR handles the issue and requires no additional PRs.
  • [x] You have validated the need for this change.

What did this PR accomplish?

  • Update to a standard structure for build scripts and checklist folder.

rejahrehim avatar Jul 09 '22 07:07 rejahrehim

The following links are broken: FILE:checklist/README.md [✖] https://raw.githubusercontent.com/OWASP/wstg/master/checklist/checklist.md → Status: 404

github-actions[bot] avatar Jul 09 '22 07:07 github-actions[bot]

The following mistakes were identified:

/home/runner/work/wstg/wstg/checklist/README.md 33:89 ✖ Incorrect usage of the term: “File name”, use “filename” instead terminology

github-actions[bot] avatar Jul 09 '22 07:07 github-actions[bot]

The following links are broken: FILE:checklist/README.md [✖] https://raw.githubusercontent.com/OWASP/wstg/master/checklist/checklist.md → Status: 404

Will be created once this PR is merged.

rejahrehim avatar Jul 09 '22 07:07 rejahrehim

The following links are broken: FILE:checklist/README.md [✖] https://raw.githubusercontent.com/OWASP/wstg/master/checklist/checklist.md → Status: 404

github-actions[bot] avatar Jul 09 '22 07:07 github-actions[bot]

should we rename the folder to checklists instead of checklist (added "s")?

Otherwise looks good 👍

ThunderSon avatar Jul 10 '22 22:07 ThunderSon

Sure that seems like a good idea.

kingthorin avatar Jul 10 '22 22:07 kingthorin

The following links are broken: FILE:checklists/README.md [✖] https://raw.githubusercontent.com/OWASP/wstg/master/checklists/checklist.xlsx → Status: 404 [✖] https://raw.githubusercontent.com/OWASP/wstg/master/checklists/checklist.md → Status: 404

github-actions[bot] avatar Aug 11 '22 17:08 github-actions[bot]

should we rename the folder to checklists instead of checklist (added "s")?

Otherwise looks good 👍

Done

rejahrehim avatar Aug 11 '22 17:08 rejahrehim

The following links are broken: FILE:checklists/README.md [✖] https://raw.githubusercontent.com/OWASP/wstg/master/checklists/checklist.xlsx → Status: 404 [✖] https://raw.githubusercontent.com/OWASP/wstg/master/checklists/checklist.md → Status: 404

Will be created once this PR is merged.

rejahrehim avatar Aug 11 '22 17:08 rejahrehim

QQ, I think the checklists generation build is occurring on any/every change on the repo that's happening. Is the latest action addition we have running on every commit? 🤔

ThunderSon avatar Aug 11 '22 22:08 ThunderSon

The following links are broken: FILE:checklists/README.md [✖] https://raw.githubusercontent.com/OWASP/wstg/master/checklists/checklist.xlsx → Status: 404 [✖] https://raw.githubusercontent.com/OWASP/wstg/master/checklists/checklist.md → Status: 404

github-actions[bot] avatar Aug 12 '22 00:08 github-actions[bot]

QQ, I think the checklists generation build is occurring on any/every change on the repo that's happening. Is the latest action addition we have running on every commit? 🤔

Runs on master branch if any changes in document folder.

on:
  push:
    branches:
      - master
    paths:
      - 'document/**'

rejahrehim avatar Aug 12 '22 00:08 rejahrehim