wrongsecrets icon indicating copy to clipboard operation
wrongsecrets copied to clipboard

Optimize Github actions

Open commjoen opened this issue 1 year ago • 9 comments

In order to become more efficient in CLI time there are a bunch of things we can simplify:

  • [ ] 1. create 1 clean-install with all the sskips in place materials to have the jar file
  • [ ] 2. Change swagger action to depend on 1
  • [ ] 3. Change DAST to depend on 1
  • [ ] 4. Change Docker container creation action to depend on1
  • [ ] Optimize many of the github actions to just run once instead of twice during a PR.
  • [ ] quickfail container test if something is wrong...

commjoen avatar Mar 20 '23 08:03 commjoen

Ive noticed the docker container Github action check does not immediately fail when something goes wrong. It hangs until the timeout has been exceeded. I think this will be using a lot of your Github minutes as the timeout is 6 hours.

Might be good to add that to the fix image

RemakingEden avatar May 04 '23 07:05 RemakingEden

@commjoen I'm really interested in working on this. Please give me this incredible opportunity.

puneeth072003 avatar May 26 '23 02:05 puneeth072003

It is all yours ;-)

commjoen avatar May 26 '23 02:05 commjoen

So ive got a couple of other ideas of how to clean up the pipelines a little. @commjoen @puneeth072003 let me know if I should start another ticket or we should add to this one.

  1. Clean up test workflow output. Right now as we are running everything through maven we get a lot of output based on the build and running. I find it can be a little tricky to figure out the debug message you are actually looking for. I either think simplified output from maven or perhaps a test report that is exported with each run.

  2. Consistent naming conventions and a workflow file for each distinct piece e.g. a test workflow file and a security workflow file. The only problems I can forsee with this is that you can't move artifacts between each workflow file so if you want workflows to depend on each other it is tricky.

RemakingEden avatar May 29 '23 08:05 RemakingEden

Good to do that in this issue :-)

commjoen avatar May 29 '23 08:05 commjoen

@RemakingEden Great suggestions!! Happy to implement those

puneeth072003 avatar May 29 '23 09:05 puneeth072003

Will be picked up after https://github.com/OWASP/wrongsecrets-binaries/pull/35 :) .

commjoen avatar Aug 18 '23 05:08 commjoen

I'll start by task 3

  • [x] Change DAST to depend on 1

puneeth072003 avatar Sep 19 '23 12:09 puneeth072003

@commjoen happy to continue with the issue

puneeth072003 avatar Oct 26 '23 04:10 puneeth072003