threat-dragon icon indicating copy to clipboard operation
threat-dragon copied to clipboard

Implimentation of Dark mode

Open Shubham-Patel07 opened this issue 10 months ago • 3 comments

Summary:

This pull request is about the implementation of dark mode using state management.

preview

light mode image

dark mode image

I will improve this gradually, please review it and provide your feedback

Shubham-Patel07 avatar Apr 14 '24 15:04 Shubham-Patel07

Sure, I'll try to look into it and will know more about nativeTheme

Shubham-Patel07 avatar Apr 15 '24 04:04 Shubham-Patel07

HI @jgadsden, I've gone through nativeTheme and I've got to know that it is specific to electron setup and need to setup electron app on our current configuration. Also theme changes from the system preferences can be achieved using the current implementation. So are there any specific requirements for using nativeTheme ? Custom Theme Toggle Implementation is lot more customizable then using an nativeTheme API

Shubham-Patel07 avatar Apr 19 '24 03:04 Shubham-Patel07

What do you suggest @jgadsden ?

Shubham-Patel07 avatar Apr 20 '24 08:04 Shubham-Patel07

This PR is stale because it has been open 21 days with no activity. Remove stale label, or add a comment, otherwise it will be closed in 7 days.

github-actions[bot] avatar May 14 '24 07:05 github-actions[bot]

This PR was closed because it has been stalled for 28 days with no activity.

github-actions[bot] avatar May 22 '24 07:05 github-actions[bot]