threat-dragon
threat-dragon copied to clipboard
Window size is fixed (on Mac electron)
Describe the bug No matter how big my screen is, my window size is fixed for threat dragon. I get a huge bottom and right side border. It is possible to use more real estate than what is shown, but it is unnecessarily difficult, and dragging an object onto any of the edges results in a very rapid scrolling, which then has to be undone by deleting the object, then dragging the sliders back.
Expected behavior Drawable area should scale to the size of the screen. We have very large screens now some are 4k! Today we can't even make full use of a 1380X768 screen.
Environment
- Version: 1.3.1
- Platform: Mac OS Electron Desktop App
- OS: MacOS Catalina
- Browser: None
To Reproduce Simply maximize the window to full size. Note: Massive borders on bottom and right side of window; drawing area remains fixed. Most diagrams I have drawn the past 6 months have needed to be carefuly tweaked and optimized to fit inside the window.
Any additional context, screenshots, etc
Hello @storkinsj - yes, agreed, this is not a good look for Threat Dragon. It has been a problem for a while, with @injcristianrojas raising this in issue https://github.com/OWASP/threat-dragon-desktop/issues/84 .
It is that same root cause (or so I think) in that the drawing package is a rather old version of JointJS. It should be fixed when we migrate to mxgraph in Threat Dragon version 2.0
Do you want to add your comments into the Threat Dragon Desktop repo issues ?
https://github.com/OWASP/threat-dragon-desktop/issues
Thanks again for the suggestions, all much appreciated
+1 on this. I am experiencing the same. I would even suggest to allow to move the properties box from the right border under the edit/manage sections. This would help to increase the available screen size for the diagram display further. If possible a zoom in & out option could improve usability a lot for a bit more complex models.
We're currently working on version 2.0 (due in 2022) which is a rewrite, and implements zoom, pan, scrolling, etc. We changed the layout for the graph edit view so that the properties and threats are under the graph. This gives the graph a bit more real estate, and we are working to ensure the graph size adjusts with the screen/resolution.
Here's a screenshot with the latest work in progress: https://github.com/OWASP/threat-dragon/issues/336#issuecomment-1003290329
If anyone has feedback on that or suggestions, we are all ears!!! :smile:
Closing this as it has been fixed by the new drawing library for version 2.0