threat-dragon icon indicating copy to clipboard operation
threat-dragon copied to clipboard

New Threat Model Gets Stuck at v2 Welcome

Open lreading opened this issue 3 years ago • 2 comments

Describe the bug When creating a new threat model using GitHub auth, the guard that checks for v1 vs v2 models triggers, and you cannot navigate past it. This happens when clicking the "create a new threat model" link from the repository selection page.

To Reproduce

  • Log in using Github Auth
  • Click "open an existing threat model"
  • Select a repository
  • Select a branch
  • Click the "Create a New Threat Model" link at the top of the page

Any additional context, screenshots, etc Screenshot from 2022-02-12 23-56-47

This was set up prior to much of the other routing and configuration. Creating a new threat model using github auth isn't fully implemented yet either, as there is no option for repo/branch selection. This issue could cover all of the above, or just be picked up after the implementation of new threat models is fleshed out.

lreading avatar Feb 13 '22 04:02 lreading

Confirmed that this still happens as described

jgadsden avatar Mar 28 '22 20:03 jgadsden

Assigning to myself - I've wanted to re-work the git flow for a bit now. I think it could be done a bit more cleanly anyways. As it currently works, there's multiple pages/routes to get to a threat model, when it could be a single view with multiple components to accomplish the same goal.

lreading avatar Apr 15 '22 18:04 lreading