threat-dragon icon indicating copy to clipboard operation
threat-dragon copied to clipboard

Desktop: Landscape Diagram Export option

Open nickrmc83 opened this issue 4 years ago • 11 comments

Is your feature request related to a problem? Please describe.

👋 I've been using this great tool for a little while but we keep hitting a minor niggle which we'd love to see improved. When exporting reports using the Mac desktop app much of the time the diagrams include scrolls bars. It would be great to either be able to fit-to-width and/or output diagrams as landscape so that the scrollbars can be removed and so more space is available.

Describe the solution you'd like

The option to export diagrams in landscape to better support larger and more complex systems.

Describe alternatives you've considered

None

Additional context

nickrmc83 avatar Aug 13 '20 13:08 nickrmc83

Hello @nickrmc83 - I am glad you like Threat Dragon, and this is a good suggestion, thankyou. It would be a good enhancement to have a landscape option ... it maybe could be a tick box in app/threatmodels/desktopreport.html with this option being applied in app/threatmodels/desktopreport.js.

jgadsden avatar Aug 13 '20 14:08 jgadsden

@jgadsden Can you please assign it to me.

Yogendra0Sharma avatar Aug 14 '20 05:08 Yogendra0Sharma

@Yogendra0Sharma - all yours! thanks for taking this on

jgadsden avatar Aug 14 '20 05:08 jgadsden

Hello @Yogendra0Sharma , we may be releasing Threat Dragon at the end of this week. Do you want to get this fix in to this version 1.3.1 release?

jgadsden avatar Aug 18 '20 09:08 jgadsden

Hello @Yogendra0Sharma , we are very close to the release, do you mind if someone else works on this issue so that it can be released?

jgadsden avatar Aug 24 '20 07:08 jgadsden

Hello @Yogendra0Sharma , we are very close to the release, do you mind if someone else works on this issue so that it can be released?

Sure.

Yogendra0Sharma avatar Aug 24 '20 07:08 Yogendra0Sharma

After some working through the code, this feature requires a change to be made to the threat dragon core file : https://github.com/OWASP/threat-dragon-core/blob/main/src/threatmodels/threatmodelreport.html

and so we can put this feature back to version 1.4. This gives much more time for you @Yogendra0Sharma ? I now realise that this is not a good first issue - so I have removed the label - and if you want help on this one I can give it.

jgadsden avatar Sep 03 '20 07:09 jgadsden

Raised an issue to support this in the core repo: https://github.com/OWASP/threat-dragon-core/issues/70

jgadsden avatar Nov 18 '20 16:11 jgadsden

Transferred to threat dragon repo

jgadsden avatar Jul 08 '21 07:07 jgadsden

Is Export option implemented on the Desktop version? I have been looking for the same, but I couldn't find it.

jauharbal avatar Mar 01 '22 16:03 jauharbal

Is Export option implemented on the Desktop version? I have been looking for the same, but I couldn't find it.

Hello @jauharbal , not yet but if you are interested in coding it that would be great Cheers, Jon

jgadsden avatar Mar 01 '22 16:03 jgadsden

Issue #127 duplicates this

jgadsden avatar Jan 17 '23 06:01 jgadsden

This has been addressed in version 2.0.2 - the diagrams in the reports are scaled to fit and no longer have scroll bars

jgadsden avatar Jul 20 '23 15:07 jgadsden