threat-dragon icon indicating copy to clipboard operation
threat-dragon copied to clipboard

Published 20 hours ago • verified publisher icon OWASP

Remove Link does not always work.

Open adampurkiss opened this issue 4 years ago • 5 comments

In Windows version 1.3.1 when you delete a number of links you can get "stuck" with a link that wont delete until you press save, exit diagram and go back in. Unfortunately this does not always happen so I have not ben able to come up with foolproof steps

To Reproduce Steps to reproduce the behavior:

  1. Create a model where you have > 4 processes along with 2 or more data flows per process
  2. Delete more than one data flow link
  3. At some point the remove link button stops working
  4. Save
  5. Close Diagram
  6. Open Diagram
  7. Delete link

Expected behavior Delete should always work

Environment:

  • Platform: Desktop
  • OS: Windows
  • Version 1.3.1

adampurkiss avatar Nov 10 '20 01:11 adampurkiss

Hello @adampurkiss - this is definitely a bug, thanks for reporting it. I can not reproduce it on my my Mac, and I do not run Windows, so @andk123 could you maybe have a look at this? Unless @adampurkiss you can dive into the code and see what is going wrong?

When trying to reproduce it on 1.3.1 using Mac I tried:

  1. open the demo threat model
  2. delete links and I was able to delete all the links.

jgadsden avatar Nov 11 '20 06:11 jgadsden

Unfortunately your technology stack is not one that I have used so its unlikely I can work on this. If I run in to this again I can try to lock down on the steps but like you when I wanted to make it happen everything worked fine.

adampurkiss avatar Nov 11 '20 15:11 adampurkiss

Sure I will have a look, but yes if you run into the error again, please let us know if any different steps were taken. Thanks!

andk123 avatar Nov 11 '20 15:11 andk123

I was able to reproduce this in Mac 11.5.2 with version 1.5.3.

I made a diagram, duplicated that diagram, opened the diagram and tried to delete a link.

After saving, closing and opening it again, it worked.

juankb1024 avatar Sep 09 '21 20:09 juankb1024

Thanks @juankb1024 , I will see if I can repeat it. We are updating our version of JointJS in #236 and this may get solved during that update.

jgadsden avatar Sep 11 '21 06:09 jgadsden

Closing this as a Won't Do We have replaced the drawing library for version 2.0 onwards, so we no longer have this problem (just different problems)

jgadsden avatar Jan 17 '23 06:01 jgadsden