OWASP
Canvas reverts to small view area on save
Describe the bug: When a diagram is saved, Antv/X6 drawing package reverts the canvas size to the size of the container view The user is left with a confusing diagram and has to drag components to get them back into view Updating to antv/x6 version 2.x did not solve this, see #722
Expected behaviour: when opening a diagram, the canvas size and viewing area should match the previous sizes
Environment:
- Version: after commit 6b8f3e3, version 2.3
- Platform: both Web App and Desktop App
- OS: all of MacOS / Windows / Linux
- Browser: all of chrome, firefox, safari
To Reproduce:
- Open the example diagram
- drag a component so that the diagram canvas resizes
- save the diagram
- only a portion of the canvas is now displayed
Any additional context, screenshots, etc:
Create a model that spans more than one page vertically, note that this diagram is zoomed out to show the complete example model:
press the save button and observer that only the top page is displayed in the diagram view:
The model is still complete, zoom in and out to reframe the diagram
@jgadsden I do not get this point.
Because on my side, when I save the file, it does not revert the canvas size...
Are you saying that when he saves the file in a JSON file and then opens this JSON file again, it reverts the canvas size to the size of the container view? can you elaborate on this more?
the problem is to do with the dependencies for the version of antv/x6 that we are using : v1.35.0 or v1.35.1
I am not sure which dependency it is but we can take the v2.2.0 tag, which works, and update the dependencies which then produce the fault:
npm run clean
rm td.vue/package-lock.json
git status
npm i
grep -n2 "antv" td.vue/package-lock.json
npm run start:desktop
this means we have to update antv/x6 to version 2.x, subject of issue #722
moving this to version 2.4 it seems to be an incompatibility with antv/x6 and Vue 2 Vue is due to be migrated to away from 2.x to version 3.5.x, subject of issue #444