OFFAT icon indicating copy to clipboard operation
OFFAT copied to clipboard

Support for HTTP/2

Open henning410 opened this issue 1 year ago • 5 comments

If I understand correctly, OFFAT does not currently work for HTTP/2? I tried to fuzz some API that uses HTTP/2, but OFFAT produces

RemoteDisconnected('Remote end closed connection without response')

Is support for this planned in the future?

henning410 avatar Jun 13 '24 12:06 henning410

Unfortunately the extensive use of requests package prevent implementation of HTTP/2 as urllib3 which requests uses doesn't have nor plans to add HTTP/2

An alternative could be to migrate to: https://pypi.org/project/pycurl/ which support HTTP/2 if libcurl has HTTP/2 compiled into it

nrathaus avatar Jun 13 '24 12:06 nrathaus

Hello @dmdhrumilmistry, I have an idea for this. We could pass an argument like --http2 which would enable HTTP/2 and then implement it using httpx.

If that sounds good, can you assign this issue to me?

dr4g0n369 avatar Oct 09 '24 17:10 dr4g0n369

Hello @dmdhrumilmistry, I have an idea for this. We could pass an argument like --http2 which would enable HTTP/2 and then implement it using httpx.

If that sounds good, can you assign this issue to me?

Hey,

Sounds good to me! but currently, I'm not planning to maintain python version anymore. I've been busy lately, but I'm porting complete codebase to golang. Currently, I'm using fasthttp which sadly doesn't support http2 (at the time of writing). If you're interested in contributing to the project, then you can create a module with interface which can support http1 (fast http), http2 (net/http) and http3 (quic-go) requests.

LMK if you'd like to pick this up. Also, Note its not necessary to implement all at once, you can implement it in phases.

Golang Codebase: https://github.com/owasp-offat/offat

dmdhrumilmistry avatar Oct 09 '24 20:10 dmdhrumilmistry

Yes, I would surely like to take that up.

dr4g0n369 avatar Oct 10 '24 01:10 dr4g0n369

I'm creating new issue in golang codebase and assigning it to you.

dmdhrumilmistry avatar Oct 10 '24 05:10 dmdhrumilmistry