IoTGoat icon indicating copy to clipboard operation
IoTGoat copied to clipboard

Add build

Open parsley72 opened this issue 1 year ago • 1 comments

parsley72 avatar Oct 19 '24 00:10 parsley72

Build works for me: https://github.com/parsley72/IoTGoat/actions/runs/11412668338

parsley72 avatar Oct 19 '24 00:10 parsley72

Thank you for the PR @parsley72. Would you please summarize the functionality and some of what you intend with adding builds? Are we expected to see build artifacts are stored after one is complete? appreciate it!

scriptingxss avatar Oct 27 '24 09:10 scriptingxss

Why do you need a reason for getting the build to work? I wanted to get the build to work, it didn't work so I fixed it.

parsley72 avatar Oct 27 '24 19:10 parsley72

Thank you for getting the build to work and surfacing a gap in this project for contributors. I have added the standard OWASP Contribution guidelines that all projects abide by. Im specifically asking for 5. Your pull request includes a clear and concise description of the changes you have made. I appreciate you taking the time to fix the build issue and providing the required information to review so I can get this merged. Thank you!

scriptingxss avatar Oct 27 '24 20:10 scriptingxss

The commit comments are comprehensive and include links to sources.

parsley72 avatar Oct 27 '24 20:10 parsley72