BLT icon indicating copy to clipboard operation
BLT copied to clipboard

BLT Private Project

Open HanilJain opened this issue 1 year ago • 15 comments

Project Done #1702

Related #1090 #1685

description

BLT private project have Private Issue Page where all the Private Issue are listed and viewership can be managed. request made by any user and people who have access are listed which can be granted or declined the access. User could request access for Private Issue with message and the owner will notified by the mail , If access is granted the user will be notified through email and can view the Private Issue.

Feature

  • Request Access for Private Issue
  • Email Notification on Request Request and approval
  • viewership management of Private Issue
  • dedicated page for Private Issue management
  • Well Tested and security management

workflow

Screenshot 2024-02-04 050207

Screnshot

Request Access

Private Issue on User Profile

Private Issue Listed

Viewership Managment

HanilJain avatar Feb 03 '24 23:02 HanilJain

@DonnieBLT Sir , could you please review

HanilJain avatar Feb 03 '24 23:02 HanilJain

This has both #1691 #1729 with additional feature fixing #1090 #1685.

HanilJain avatar Feb 04 '24 00:02 HanilJain

I think this may need an update / conflict check

DonnieBLT avatar Feb 07 '24 21:02 DonnieBLT

Can you please resolve the conflicts and update the branch?

DonnieBLT avatar Feb 08 '24 04:02 DonnieBLT

@DonnieBLT Done please check.

HanilJain avatar Feb 08 '24 18:02 HanilJain

@DonnieBLT are there any more changes to be made in it ?

HanilJain avatar Feb 13 '24 11:02 HanilJain

Tested it and it works perfect. Some Fixes:

  1. Use tailwind instead of CSS and bootstrap in added html (we are migrating to tailwind)
  2. /issue/pk page is deprecated and will be removed in future please also add support for /issue2/pk
  3. change model name RequestAccess -> RequestIssueAccess (in future we will add access models for company and domains also, better we keep naming convention good)

AtmegaBuzz avatar Feb 21 '24 20:02 AtmegaBuzz

Also, resolve any conversations that have been resolved please

DonnieBLT avatar Feb 23 '24 06:02 DonnieBLT

Tested it and it works perfect. Some Fixes:

  1. Use tailwind instead of CSS and bootstrap in added html (we are migrating to tailwind)
  2. /issue/pk page is deprecated and will be removed in future please also add support for /issue2/pk
  3. change model name RequestAccess -> RequestIssueAccess (in future we will add access models for company and domains also, better we keep naming convention good)

@AtmegaBuzz changes have been made in 79c67d6fcdffb90bb6a7d025c949a5ef1512070d could you Please review

HanilJain avatar Feb 24 '24 00:02 HanilJain

@HanilJain can you resolve the merge conflicts, rest looks good to me

AtmegaBuzz avatar Feb 25 '24 07:02 AtmegaBuzz

Please look into some code improvement suggestions:

@arkid15r Thanks for the suggestions they were really helpful. if there is anything please tell.

HanilJain avatar Feb 27 '24 09:02 HanilJain

Great work @HanilJain , Happy to have someone this skilled as a peer

Sarthak5598 avatar Mar 02 '24 07:03 Sarthak5598

Great work @HanilJain , Happy to have someone this skilled as a peer

Thanks @Sarthak5598 , but its nothing like that : )

HanilJain avatar Mar 02 '24 08:03 HanilJain

@DonnieBLT Made all suggested changes 7e2081ec067c42cd88735e9802a5b70a1c5ccffd

HanilJain avatar Mar 07 '24 18:03 HanilJain

Can you please split these into smaller PRs

Yup i'll do it

HanilJain avatar Mar 09 '24 19:03 HanilJain

can you please split this into smaller PRs?

DonnieBLT avatar May 25 '24 20:05 DonnieBLT

@DonnieBLT For sure I have planned do it in upcoming few days.

HanilJain avatar May 26 '24 11:05 HanilJain