BLT
BLT copied to clipboard
BLT Private Project
Project Done #1702
Related #1090 #1685
description
BLT private project have Private Issue Page where all the Private Issue are listed and viewership can be managed. request made by any user and people who have access are listed which can be granted or declined the access. User could request access for Private Issue with message and the owner will notified by the mail , If access is granted the user will be notified through email and can view the Private Issue.
Feature
- Request Access for Private Issue
- Email Notification on Request Request and approval
- viewership management of Private Issue
- dedicated page for Private Issue management
- Well Tested and security management
workflow
Screnshot
@DonnieBLT Sir , could you please review
This has both #1691 #1729 with additional feature fixing #1090 #1685.
I think this may need an update / conflict check
Can you please resolve the conflicts and update the branch?
@DonnieBLT Done please check.
@DonnieBLT are there any more changes to be made in it ?
Tested it and it works perfect. Some Fixes:
- Use tailwind instead of CSS and bootstrap in added html (we are migrating to tailwind)
- /issue/pk page is deprecated and will be removed in future please also add support for /issue2/pk
- change model name RequestAccess -> RequestIssueAccess (in future we will add access models for company and domains also, better we keep naming convention good)
Also, resolve any conversations that have been resolved please
Tested it and it works perfect. Some Fixes:
- Use tailwind instead of CSS and bootstrap in added html (we are migrating to tailwind)
- /issue/pk page is deprecated and will be removed in future please also add support for /issue2/pk
- change model name RequestAccess -> RequestIssueAccess (in future we will add access models for company and domains also, better we keep naming convention good)
@AtmegaBuzz changes have been made in 79c67d6fcdffb90bb6a7d025c949a5ef1512070d could you Please review
@HanilJain can you resolve the merge conflicts, rest looks good to me
Please look into some code improvement suggestions:
@arkid15r Thanks for the suggestions they were really helpful. if there is anything please tell.
Great work @HanilJain , Happy to have someone this skilled as a peer
Great work @HanilJain , Happy to have someone this skilled as a peer
Thanks @Sarthak5598 , but its nothing like that : )
@DonnieBLT Made all suggested changes 7e2081ec067c42cd88735e9802a5b70a1c5ccffd
Can you please split these into smaller PRs
Yup i'll do it
can you please split this into smaller PRs?
@DonnieBLT For sure I have planned do it in upcoming few days.