RapidCRC-Unicode icon indicating copy to clipboard operation
RapidCRC-Unicode copied to clipboard

Support for xxh3-64

Open vivadavid opened this issue 1 year ago • 2 comments

Hi,

I wanted to know if support for xxh3-64 could be added. Thanks!

vivadavid avatar May 21 '24 08:05 vivadavid

Would be nice. I see that blake3 was added, which I read speed is quite fast too.

For reference here is xxh3 or xxhash: https://xxhash.com/ https://github.com/Cyan4973/xxHash/

o-data avatar Sep 02 '24 04:09 o-data

I want xxh3 support too. I would like xxh3-128.

fmnijk avatar Jan 28 '25 09:01 fmnijk

I might have some time again to work on rcrc and could add xxh3. But I don't really want to add too many variants, would xxh3-128 be enough for all your use cases?

OV2 avatar Mar 01 '25 16:03 OV2

I might have some time again to work on rcrc and could add xxh3. But I don't really want to add too many variants, would xxh3-128 be enough for all your use cases?

As stated in my original post, xxh3-64 would be really appreciated, as speed is my main concern. Thanks.

vivadavid avatar Mar 01 '25 18:03 vivadavid

Both xxh3-128 and xxh3-64 are extremely fast. Disk I/O is typically the main bottleneck, not hash calculation. Fastcopy also use xxh3-128 in default.

fmnijk avatar Mar 02 '25 02:03 fmnijk

xxHash3-64 is the default implementation in Teracopy: https://blog.codesector.com/2023/07/04/teracopy-3-10/

vivadavid avatar Mar 02 '25 08:03 vivadavid

I mentioned FastCopy to state that both XXH3-128 and XXH3-64 are extremely fast. If XXH3-64 actually offered a speed advantage that is too significant to ignore, they would definitely use it. Both XXH3-64 and XXH3-128 are good options.

fmnijk avatar Mar 02 '25 10:03 fmnijk

I've finally found the time to clean up and push a new installer.

OV2 avatar Sep 27 '25 17:09 OV2

Hi,

The changelog says: 'Added xxhash3 and xxhash3-128'.

In the programme, on the list of hashes, I find XXH3 and XXH128:

Image

So, I presume that XXH3 corresponds to xxh3-64 and that XXH128 corresponds to xxh3-128: is that correct?

Also, I can't find XXH3 on the Shell Extension.

Image

Would there be a way to add it?

Thanks.

vivadavid avatar Sep 27 '25 18:09 vivadavid

So, I presume that XXH3 corresponds to xxh3-64 and that XXH128 corresponds to xxh3-128: is that correct?

Yes, those are the names used by xxhash.

I have not yet reworked the shell extension.

OV2 avatar Sep 27 '25 19:09 OV2

By the way, I forgot to say thank you for implementing the hash. You even implemented both variants.

As for the shell extension, it'd be great if you could update it whenever you have the chance.

As XXH3 isn't available on the list of hashes, I checked Open all hash files, but when I select some files in Windows File Explorer and I click on OpenCRC and then on Open all hash files, my files aren't listed and I can't create the hash.

vivadavid avatar Sep 27 '25 21:09 vivadavid

"Open all hash files" means "open all sfv/md5/etc. files you can find and try to verify them".

For your use case you simply need to use "Open" - this will open rapidcrc with all selected files in them (and the hashes calculated you've configured as default). You can then use XXH3 or XXH128 from the Hash File button (or from one of the two direct buttons, if you've set them up for those hashes).

OV2 avatar Sep 27 '25 21:09 OV2

Working now: thanks!

vivadavid avatar Sep 27 '25 22:09 vivadavid