djangosaml2idp icon indicating copy to clipboard operation
djangosaml2idp copied to clipboard

Published 20 hours ago • verified publisher icon OTA-Insight

Fix case request is already signed

Open Amertz08 opened this issue 3 years ago • 3 comments

Fixes #121

Amertz08 avatar Apr 05 '21 23:04 Amertz08

So what I did for now is comment out the fix. Modify the settings to actually sign the response. Then wrote a test to verify the 500. That test will fail w/ 500 since the code is commented out. You can uncomment the fix and see the test pass (i.e. fixes the bug). Issue I'm running into is inline modifying the IDP config for that test and that test only. Modifying the actual settings file vs. in the test via a fixture causes other tests to fail.

Amertz08 avatar Apr 09 '21 02:04 Amertz08

So I am not running into any issues running the tests locally. Not sure what the issue in the build process is.

Amertz08 avatar May 26 '21 00:05 Amertz08

Can this PR be merged?

charron-tom avatar Sep 30 '21 18:09 charron-tom