[Feature] Probe use built-in, discarded healthcheck.sh

[muicoder]

Description

Feature: #443

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

• [x] Testing has been performed
• [x] No functionality is broken
• [ ] Documentation updated

[muicoder]

@shubham-cmyk Tested as expected, please check.

[muicoder]

@shubham-cmyk Can you merge?

[shubham-cmyk]

@muicoder I have to test it this would be merged in coming release

[genofire]

any update @muicoder ?

[muicoder]

any update @muicoder ?

All as expected

[genofire]

Ups sorry, i mean @shubham-cmyk for merging

[shubham-cmyk]

To be added in v0.15.0

[muicoder]

This can also be merged.

[shubham-cmyk]

This is not complete PR! You are only passing fewer keys and cert

if params.TLSConfig.CaKeyFile != "" {
			caCert = params.TLSConfig.CaKeyFile
		}

check here https://redis.io/docs/management/security/encryption/ :

./src/redis-cli --tls \
    --cert ./tests/tls/redis.crt \
    --key ./tests/tls/redis.key \
    --cacert ./tests/tls/ca.crt

[muicoder]

Configured a full TLS certificate.

[muicoder]

Improved loading TLS certificates in the ENV mode on the probe (tested).

[shubham-cmyk]

@muicoder I won't be merged in the v0.15.0 because it would also require the change in the redis image and remove the existing code that uses the health-check method. I would merge it after releasing v0.15.0 this change would be visible from v0.16.0.

This might require more testing from my side.

[genofire]

any update?

[genofire]

is there a reason, why this was closed?

does any other patch get the exporter in combination with sentinal working?

[muicoder]

is there a reason, why this was closed?

does any other patch get the exporter in combination with sentinal working?

Change probeCommand to append mode Repush later based on master branch (conflicting)

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 36.10%. Comparing base (d121d86) to head (5204908). Report is 14 commits behind head on master.

Files	Patch %	Lines
k8sutils/statefulset.go	0.00%	24 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #444      +/-   ##
==========================================
+ Coverage   35.20%   36.10%   +0.90%     
==========================================
  Files          19       19              
  Lines        3213     2631     -582     
==========================================
- Hits         1131      950     -181     
+ Misses       2015     1613     -402     
- Partials       67       68       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[wkd-woo]

any update?

[muicoder]

any update?

updated

[shubham-cmyk]

I would get this merged in this release

[drivebyer]

I noticed that it has been a long time since it was last updated, but I think this change is very important. I would like to raise another PR to implement it.

[muicoder]

I noticed that it has been a long time since it was last updated, but I think this change is very important. I would like to raise another PR to implement it.

Welcome 👍🏻 😀 👍🏼 👍🏽

[drivebyer]

It's been done by https://github.com/OT-CONTAINER-KIT/redis-operator/pull/907, thanks @muicoder