Templates for Replication and Sentinel do not match CRDs

[zumbuschms]

What version of redis operator are you using? 0.18.0

Does this issue reproduce with the latest release? Yes

What operating system and processor architecture are you using (kubectl version)?

• Azure Kubernetes Services

$ kubectl version
Client Version: v1.29.2
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.29.4

• x64

What did you do?

• downloaded latest version of Redis Helm charts from Github
  • Redis Operator 0.18.0
  • Redis Replication 0.16.0
  • Redis Sentinel 0.16.1
• unzipped all helm charts to local disk
• deployed Redis Operator without any modifications into a completely blank cluster
• manually deployed TLS certificates for Replication and Sentinel pods via kubectl secret create
• adjusted the values.yaml for Redis Replication to my needs
  • enabled and configured externalConfig to configure TLS
  • enabled redisExporter
  • configured TLS settings to use the configured TLS certificate secret
• adjusted the values.yaml for Redis Sentinel to my needs
  • enabled and configured externalConfig
  • enabled redisExporter
  • configured TLS settings to use the configured TLS certificate secret
• deployed Redis Replication helm chart
• deployed Redis Sentinel helm chart

What did you expect to see?

• working deployment
• deployment without warnings

What did you see instead?

• external config was not applied to Replication pods
• Redis Sentinal was correctly configured
• warning message about unknown field spec.redisExporter.redisConfig
• warning message about unknown field spec.redisExporter.redisConfig

Proposed fix

• remove the section for redisConfig from redis-sentinel.yaml as the configration is already handled by redisSentinelConfig
• fix the indentation of redisConfig in redis-sentinel.yaml to match the indentation of redisExporter

Pull Request I'll provide a pull request after I figured out the test scenarios for this.