otoole
otoole copied to clipboard
[Bug]: config validation cannot deal with ResultPath
The Issue
There are two related bugs to do with ResultsPath.
- If ResultsPath is not specified in the
config.yamlfile, but listed in the datafile, the validation does not provide the correct error. - If the ResultsPath is specified in the
config.yamlfile, the type of the parameter (string) is not handled correctly by the validation.
Expected Behavior
- The validation code should identify that ResultsPath is not listed (amply returns an error)
- The validation code should handle parameters with a string type
Steps To Reproduce
-
a. Add
ResultsPath := ./a/path/to/resultsto datafile calledfile_with_resultspath.txtb. Runotoole convert datafile datafile file_with_resultspath.txt test.txt config.yaml -
a. Add entry to
config.yamlfile forResultsPathResultsPath: indices: [] type: param dtype: str default: resultsb. Add
ResultsPath := ./a/path/to/resultsto datafile calledfile_with_resultspath.txtc. Runotoole convert datafile datafile file_with_resultspath.txt test.txt config.yaml
Log output
ParseException: Expected end of text, found 'p' (at char 2069), (line:23, col:1) (at char 0), (line:1, col:1)
Operating System
MacOS
What version of otoole are you running?
1.1.2
Possible Solution
No response
Anything else?
No response
This can supersede issue #103. That issue describes adding ResultsPath to the now deprecated datapackage, but notes a similar issue in trying to use ResultsPath