osemosys_global icon indicating copy to clipboard operation
osemosys_global copied to clipboard

Add TimeSlice Defenitions in the Config File

Open trevorb1 opened this issue 4 years ago • 4 comments

trevorb1 avatar Oct 21 '21 15:10 trevorb1

How are we wanting to add timeslice definitions to the config file? Right now it looks like the timeslice structure is defined in OPG_TS_Data.py here...

image

In the config file we currently only give an option to include daytype as True or False. Are we wanting to go further and give more flexibility? (ie. separate by hours, days, months, seasons)

trevorb1 avatar Nov 17 '21 00:11 trevorb1

@abhishek0208 - Let's also adjust the TS naming convention to make it S01D01 so we can have a 2 digit season and a 2 digit day.

tniet avatar Nov 18 '21 16:11 tniet

The ts_dayparts.csv and ts_seasons.csv info to get moved to the config file

trevorb1 avatar Nov 18 '21 16:11 trevorb1

Added daypart and seasons to config file. In the most recent ts_seasons.csv file there are also columns for month name (January, February, ...) and days in the season. Instead of putting these into the config file, its probably just easier to use the datetime python library. These columns are only used in the visualization script, so I will hold off on making that change until we are all on the same page with the current state of everything

trevorb1 avatar Nov 22 '21 19:11 trevorb1

@trevorb1 @tniet I think that the current implementation of time slices in the config file is appropriate? Can we close this issue until we have a reason (and bandwidth) to make further adjustments?

maartenbrinkerink avatar Sep 04 '24 17:09 maartenbrinkerink

Fine by me! :)

trevorb1 avatar Sep 04 '24 18:09 trevorb1