distortionizer icon indicating copy to clipboard operation
distortionizer copied to clipboard

Convert shader reading code from C-style to C++ iostreams

Open rpavlik opened this issue 9 years ago • 2 comments

https://github.com/sensics/distortionizer/blob/master/shaders/undistort_shader.cpp#L94

I will refrain from passing judgement, recognizing that people are familiar with different things :smile: , just acknowledge that the code there can be made better or at least more idiomatic.

I can do it pretty quickly, if I get a chance (it's a handful of lines tops), though I'm not sure when that gets invoked so I'm not sure I'd be able to confidently say I didn't break it.

cc @russell-taylor

rpavlik avatar Feb 20 '15 16:02 rpavlik

Thanks for pointing this out. Step 1: Copy-paste from an existing project. Step 2: Hand off code that is halfway written before I've had the chance to check and clean up.

The same excuse won't work for VRPN, of course. Looking forward to using standard libraries there as well. You can assign this to me if you want, but I won't get to it until after the latency is licked.

russell-taylor avatar Feb 20 '15 19:02 russell-taylor

LOL, no worries, I totally get the "hand off partially finished tool" thing. Just wanted to put this into the issue tracker while I was doing the same with other stuff.

rpavlik avatar Feb 20 '15 19:02 rpavlik