OSVR-Core icon indicating copy to clipboard operation
OSVR-Core copied to clipboard

VRPN submodule needs bump to fix build

Open drlight-code opened this issue 7 years ago • 3 comments

On this debian testing system, using gcc 6.2.1, building the vrpn submodule fails with

[  3%] Building CXX object vendor/vrpn/CMakeFiles/vrpnserver.dir/vrpn_Connection.C.o
/home/pschmitz/development/OSVR/OSVR-Core/vendor/vrpn/vrpn_Connection.C: In function ‘int vrpn_start_server(const char*, char*, char*, const char*)’:
/home/pschmitz/development/OSVR/OSVR-Core/vendor/vrpn/vrpn_Connection.C:2540:24: error: aggregate ‘vrpn_start_server(const char*, char*, char*, const char*)::wait status’ has incomplete type and cannot be defined
             union wait status;

Updating the submodule to current master (9cfc1a5) makes the error go away and all of OSVR-Core build successfully. Maybe a submodule bump is required.

drlight-code avatar Dec 13 '16 15:12 drlight-code

Yes, one is required, and there's a pull request #468 that's a bit outdated already (I updated the VRPN build system after that point).

I'll go through and make sure my CMake files are updated across the board then do the bump.

rpavlik avatar Dec 13 '16 19:12 rpavlik

I'm trying to build osvr for Linux on Ubuntu 16.10 (using gcc 6.2.0), and I'm hitting the same error as above. I'm a bit new to OSVR; can someone tell me how to update the VRPN submodule to the current master version?

isantop avatar Jan 04 '17 17:01 isantop

You can just go into the vendor/vrpn folder and say git checkout master. However if you do a git submodule update in the top folder afterwards, this will be reset to the pinned submodule commit (e75e92c1) so you'd have to repeat that.

drlight-code avatar Jan 04 '17 18:01 drlight-code