OsrsBot
OsrsBot copied to clipboard
[SUGGESTION] Equipment .vs Inventory signature irregularity with containsOneOf
Equipment:
public boolean containsOneOf(int... items)
Inventory:
public boolean containsOneOf(final Integer... itemID)
not a huge deal here but i think we should have matching sigs across the board.
Yeah, I agree. Consistency is pretty important in any API. I think it got changed a little while back from a PR.
i'd be happy to identify a few more changes needed (provided its not going to annoy anyone)
Feel free. It won't bother me. I absolutely welcome any contributions.