OsrsBot icon indicating copy to clipboard operation
OsrsBot copied to clipboard

[SUGGESTION] Equipment .vs Inventory signature irregularity with containsOneOf

Open analtevs opened this issue 2 years ago • 3 comments

Equipment:

public boolean containsOneOf(int... items)

Inventory:

public boolean containsOneOf(final Integer... itemID)

not a huge deal here but i think we should have matching sigs across the board.

analtevs avatar Nov 18 '22 01:11 analtevs

Yeah, I agree. Consistency is pretty important in any API. I think it got changed a little while back from a PR.

GigiaJ avatar Nov 18 '22 05:11 GigiaJ

i'd be happy to identify a few more changes needed (provided its not going to annoy anyone)

analtevs avatar Nov 18 '22 05:11 analtevs

Feel free. It won't bother me. I absolutely welcome any contributions.

GigiaJ avatar Nov 18 '22 06:11 GigiaJ