echopype icon indicating copy to clipboard operation
echopype copied to clipboard

AZFP ULS6 beta version, ULS5 fixes

Open dash-uvic opened this issue 1 month ago • 6 comments

ULS5 Bug fixes:

  • fixed recursive bug for corrupted files
  • fixed RepeatedField not applying correctly ULS6 updates:
  • Added AZFP Nano (single channel) compatibility
  • Added compatibility for beta version of ULS6 standard
  • Refractored code to inherit ULS5 as a base class
  • Added additional tests for ULS6 to include Paros sensors

dash-uvic avatar Dec 02 '25 16:12 dash-uvic

I haven't gotten around to upload the test data to GitHub release assets just yet. Traveling tomorrow, so will try Wednesday...

leewujung avatar Dec 02 '25 22:12 leewujung

Hey @dash-uvic : I got the test data you sent me as a staged asset in #1582. It’s merged so if you pull from main now you should have all the right files.

leewujung avatar Dec 06 '25 15:12 leewujung

Codecov Report

:x: Patch coverage is 94.03748% with 35 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 85.27%. Comparing base (d371686) to head (596d471). :warning: Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
echopype/convert/parse_uls6.py 89.43% 26 Missing :warning:
echopype/convert/parse_azfp.py 92.06% 5 Missing :warning:
echopype/convert/parse_uls5.py 97.22% 4 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1581      +/-   ##
==========================================
+ Coverage   84.95%   85.27%   +0.32%     
==========================================
  Files          79       80       +1     
  Lines        6998     7042      +44     
==========================================
+ Hits         5945     6005      +60     
+ Misses       1053     1037      -16     
Flag Coverage Δ
unittests 85.27% <94.03%> (+0.32%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Dec 06 '25 19:12 codecov-commenter

@dash-uvic: I pulled the update assets in and the current tests all passed. Are there additional tests or code you want to add?

leewujung avatar Dec 07 '25 15:12 leewujung

@leewujung I've done the suggested changes and included comments from [1505] and moved the Sv_offset to calibration. Just need to write a test for the new Sv interpolation and I'll push.

dash-uvic avatar Dec 17 '25 23:12 dash-uvic

@dash-uvic : Awesome. Looking forward to it!

leewujung avatar Dec 18 '25 18:12 leewujung

Hi @dash-uvic, the error currently raised in the tests is fixed in #1591, so fetching the latest from upstream should resolve it! Cheers!

LOCEANlloydizard avatar Dec 27 '25 10:12 LOCEANlloydizard

@dash-uvic: I pulled in the upstream and everything runs through fine, so you should be good to go on adding additional tests for Sv offset.

leewujung avatar Dec 31 '25 23:12 leewujung