grass icon indicating copy to clipboard operation
grass copied to clipboard

[Feat] Use common layers/dockerfile for Ubuntu wxGUI docker image

Open echoix opened this issue 4 months ago • 3 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Now, we are using different Dockerfiles for Ubuntu and Ubuntu with wxPython GUI. The Dockerfile for Ubuntu already contains stages to build a GUI image, but is unused. Now that we build some core dependent libraries from source, we might as well reuse them as much as possible.

Describe the solution you'd like A clear and concise description of what you want to happen.

By carefully designing the layers of the common build stages, we could reuse layers as is for both images, and install additional gui libraries later on (adding a layer with more dependencies). All layers (and stages) before our grass compilation should be common in both images.

Also make sure that the cache scope allows sharing of both. Otherwise, if really not possible, build both images in the same job, so the build cache exists on the host.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

echoix avatar Oct 15 '25 18:10 echoix

Testing a version with re-ordered build stages here: https://github.com/ninsbl/grass/pull/15 and more specificly here: https://github.com/ninsbl/grass/actions/runs/18677226036/job/53249788035?pr=15 Will open a PR once I am somewhat comfortable with the updated Dockerfiles...

ninsbl avatar Oct 21 '25 08:10 ninsbl

Testing a version with re-ordered build stages here: ninsbl#15 and more specificly here: https://github.com/ninsbl/grass/actions/runs/18677226036/job/53249788035?pr=15 Will open a PR once I am somewhat comfortable with the updated Dockerfiles...

I looked at it

echoix avatar Oct 21 '25 11:10 echoix

@echoix Can you please update the description to reflect the current state with #6534 and clean up the template text there?

wenzeslaus avatar Nov 21 '25 03:11 wenzeslaus