grass icon indicating copy to clipboard operation
grass copied to clipboard

[Bug] Allow periodic update workflow to create a branch

Open echoix opened this issue 1 year ago • 2 comments

Describe the bug

The periodic update workflow, that runs each month, failed today to create a pull request because of branch naming rules' conventions.

To reproduce

  1. See https://github.com/OSGeo/grass/actions/runs/10282750517/job/28455092371

Expected behavior

Relax naming rule conventions to allow the specified branch (by GitHub actions or the person with the PAT used for it).

At the same time, it would be nice to also allow branches starting with revert- followed by a series of numbers corresponding to the PR's number, then followed by another dash. This is what the GitHub interface generates when using the "revert" feature on a merged PR. It is currently unusable for now.

Screenshots

System description

Main at ref 1527322f85cd465437e4f71eae5ce93e751466ea

echoix avatar Aug 07 '24 11:08 echoix

See related #3308. There are alternatives to be explored.

nilason avatar Aug 15 '24 06:08 nilason

In either way, we still have some branch name patterns to allow in the repos settings, as we were too strict in June when changing these settings (as we weren't strict enough the last iteration and had unexpected situations where branches were made in the repo out of a fork)

echoix avatar Aug 15 '24 10:08 echoix

This is still not changed, we cannot use the revert a PR button

image

@nilason do you have access to the settings yourself?

echoix avatar Dec 28 '24 12:12 echoix

The current rules are:

For all branches, we have Restrict creations (Only allow users with bypass permission to create matching refs.) Maintain and Admin Roles are excluded from that (by us) so that they can create release branches, but Write members of the core team cannot. Renovate App is also excluded to create its own branches.

The branch naming rules are in Enterprise in Restrict branch names and is basically a pattern. We are not using it now. However, the feature itself seems to be enabled for us. (OSGeo got Enterprise recently or I just don't know about it?)

Our Maintain Role ("sub-team") is the same people as Admin, so some people from Write could be upgraded to Maintain. Or we can use the naming rules at this point. Or both.

wenzeslaus avatar Dec 30 '24 16:12 wenzeslaus

(OSGeo got Enterprise recently or I just don't know about it?)

No, the Current plan is "GitHub Free":

image

neteler avatar Dec 30 '24 21:12 neteler