grass
grass copied to clipboard
CI(deps): Update dependency pylint to v3
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| pylint (changelog) | 2.12.2 -> 3.3.1 |
Release Notes
pylint-dev/pylint (pylint)
v3.3.1
What's new in Pylint 3.3.1?
Release date: 2024-09-24
False Positives Fixed
-
Fix regression causing some f-strings to not be inferred as strings.
Closes #9947
v3.3.0
Release date: 2024-09-20
Changes requiring user actions
-
We migrated
symilarto argparse, from getopt, so the error and help output changed (for the better). We exit with 2 instead of sometime 1, sometime 2. The error output is not captured by the runner anymore. It's not possible to use a value for the boolean options anymore (--ignore-comments 1should become--ignore-comments).Refs #9731
New Features
-
Add new
declare-non-sloterror which reports when a class has a__slots__member and a type hint on the class is not present in__slots__.Refs #9499
New Checks
-
Added
too-many-positional-argumentsto allow distinguishing the configuration for too many total arguments (with keyword-only params specified after*) from the configuration for too many positional-or-keyword or positional-only arguments.As part of evaluating whether this check makes sense for your project, ensure you adjust the value of
--max-positional-arguments.Closes #9099
-
Add
using-exception-groups-in-unsupported-versionandusing-generic-type-syntax-in-unsupported-versionfor uses of Python 3.11+ or 3.12+ features on lower supported versions provided with--py-version.Closes #9791
-
Add
using-assignment-expression-in-unsupported-versionfor uses of:=(walrus operator) on Python versions below 3.8 provided with--py-version.Closes #9820
-
Add
using-positional-only-args-in-unsupported-versionfor uses of positional-only args on Python versions below 3.8 provided with--py-version.Closes #9823
-
Add
unnecessary-default-type-argsto thetypingextension to detect the use of unnecessary default type args fortyping.Generatorandtyping.AsyncGenerator.Refs #9938
False Negatives Fixed
-
Fix computation of never-returning function:
Neveris handled in addition toNoReturn, and priority is given to the explicit--never-returning-functionsoption.Closes #7565.
-
Fix a false negative for
await-outside-asyncwhen await is inside Lambda.Refs #9653
-
Fix a false negative for
duplicate-argument-nameby includingpositional-only,*argsand**kwargsarguments in the check.Closes #9669
-
Fix false negative for
multiple-statementswhen multiple statements are present onelseandfinallylines oftry.Refs #9759
-
Fix false negatives when
isinstancedoes not have exactly two arguments. pylint now emits atoo-many-function-argsorno-value-for-parameterappropriately forisinstancecalls.Closes #9847
Other Bug Fixes
-
--enablewith--disable=allnow produces an error, when an unknown msg code is used. Internalpylintmessages are no longer affected by--disable=all.Closes #9403
-
Impossible to compile regexes for paths in the configuration or argument given to pylint won't crash anymore but raise an argparse error and display the error message from
re.compileinstead.Closes #9680
-
Fix a bug where a
tox.inifile with pylint configuration was ignored and it exists in the current directory..cfgand.inifiles containing aPylintconfiguration may now use a section named[pylint]. This enhancement impacts the scenario where these file types are used as defaults when they are present and have not been explicitly referred to, using the--rcfileoption.Closes #9727
-
Improve file discovery for directories that are not python packages.
Closes #9764
Other Changes
-
Remove support for launching pylint with Python 3.8. Code that supports Python 3.8 can still be linted with the
--py-version=3.8setting.Refs #9774
-
Add support for Python 3.13.
Refs #9852
Internal Changes
-
All variables, classes, functions and file names containing the word 'similar', when it was, in fact, referring to 'symilar' (the standalone program for the duplicate-code check) were renamed to 'symilar'.
Closes #9734
-
Remove old-style classes (Python 2) code and remove check for new-style class since everything is new-style in Python 3. Updated doc for exception checker to remove reference to new style class.
Refs #9925
v3.2.7
What's new in Pylint 3.2.7?
Release date: 2024-08-31
False Positives Fixed
-
Fixed a false positive
unreachableforNoReturncoroutine functions.Closes #9840
Other Bug Fixes
-
Fix crash in refactoring checker when calling a lambda bound as a method.
Closes #9865
-
Fix a crash in
undefined-loop-variablewhen providing theiterableargument toenumerate().Closes #9875
-
Fix to address indeterminacy of error message in case a module name is same as another in a separate namespace.
Refs #9883
v3.2.6
What's new in Pylint 3.2.6?
Release date: 2024-07-21
False Positives Fixed
-
Quiet false positives for
unexpected-keyword-argwhen pylint cannot determine which of two or more dynamically defined classes is being instantiated.Closes #9672
-
Fix a false positive for
missing-param-docwhere a method which is decorated withtyping.overloadwas expected to have a docstring specifying its parameters.Closes #9739
-
Fix a regression that raised
invalid-nameon class attributes merely overriding invalid names from an ancestor.Closes #9765
-
Treat
assert_never()the same way when imported fromtyping_extensions.Closes #9780
-
Fix a false positive for
consider-using-min-max-builtinwhen the assignment target is an attribute.Refs #9800
Other Bug Fixes
-
Fix an
AssertionErrorarising from properties that return partial functions.Closes #9214
-
Fix a crash when a subclass extends
__slots__.Closes #9814
v3.2.5
What's new in Pylint 3.2.5 ?
Release date: 2024-06-28
Other Bug Fixes
-
Fixed a false positive
unreachable-codewhen usingtyping.Anyas return type in python 3.8, thetyping.NoReturnare not taken into account anymore for python 3.8 however.Closes #9751
v3.2.4
What's new in Pylint 3.2.4?
Release date: 2024-06-26
False Positives Fixed
-
Prevent emitting
possibly-used-before-assignmentwhen relying on names only potentially not defined in conditional blocks guarded by functions annotated withtyping.Neverortyping.NoReturn.Closes #9674
Other Bug Fixes
-
Fixed a crash when the lineno of a variable used as an annotation wasn't available for
undefined-variable.Closes #8866
-
Fixed a crash when the
startvalue in anenumeratewas non-constant and impossible to infer (like inenumerate(apples, start=int(random_apple_index)) forunnecessary-list-index-lookup.Closes #9078
-
Fixed a crash in
symilarwhen the-dor-ishort option were not properly recognized. It's still impossible to do-d=1(you must do-d 1).Closes #9343
v3.2.3
False Positives Fixed
-
Classes with only an Ellipsis (
...) in their body do not trigger 'multiple-statements' anymore if they are inlined (in accordance with black's 2024 style).Closes #9398
-
Fix a false positive for
redefined-outer-namewhen there is a name defined in an exception-handling block which shares the same name as a local variable that has been defined in a function body.Closes #9671
-
Fix a false positive for
use-yield-fromwhen using the return value from theyieldatom.Closes #9696
v3.2.2
What's new in Pylint 3.2.2?
Release date: 2024-05-20
False Positives Fixed
-
Fix multiple false positives for generic class syntax added in Python 3.12 (PEP 695).
Closes #9406
-
Exclude context manager without cleanup from
contextmanager-generator-missing-cleanupchecks.Closes #9625
v3.2.1
What's new in Pylint 3.2.1?
Release date: 2024-05-18
False Positives Fixed
-
Exclude if/else branches containing terminating functions (e.g.
sys.exit()) frompossibly-used-before-assignmentchecks.Closes #9627
-
Don't emit
typevar-name-incorrect-variancewarnings for PEP 695 style TypeVars. The variance is inferred automatically by the type checker. Adding_coor_contrasuffix can help to reason about TypeVar.Refs #9638
-
Fix a false positive for
possibly-used-before-assignmentwhen usingtyping.assert_never()(3.11+) to indicate exhaustiveness.Closes #9643
Other Bug Fixes
-
Fix a false negative for
--ignore-patternswhen the directory to be linted is specified using a dot(.) and all files are ignored instead of only the files whose name begin with a dot.Closes #9273
-
Restore "errors / warnings by module" section to report output (with
-ry).Closes #9145
-
trailing-comma-tupleshould now be correctly emitted when it was disabled globally but enabled via local message control, after removal of an over-optimisation.Refs #9608
-
Add
--prefer-stubs=yesoption to opt-in to the astroid 3.2 feature that prefers.pyistubs over same-named.pyfiles. This has the potential to reduceno-membererrors but at the cost of more errors such asnot-an-iterablefrom function bodies appearing as....Defaults to
no.
Internal Changes
-
Update astroid version to 3.2.1. This solves some reports of
RecursionErrorand also makes the prefer .pyi stubs feature in astroid 3.2.0 opt-in with the aforementioned--prefer-stubs=yoption.Refs #9139
v3.2.0
What's new in Pylint 3.2.0?
Release date: 2024-05-14
Of note: a github reporter, two new checks (possibly-used-before-assignment and contextmanager-generator-missing-cleanup), performance improvements, and an astroid upgrade providing support for @overload and .pyi stubs.
New Features
-
Understand
six.PY2andsix.PY3for conditional imports.Closes #3501
-
A new
githubreporter has been added. This reporter returns the output ofpylintin a format that Github can use to automatically annotate code. Use it withpylint --output-format=githubon your Github Workflows.Closes #9443.
New Checks
-
Add check
possibly-used-before-assignmentwhen relying on names after anif/elseswitch when one branch failed to define the name, raise, or return.Closes #1727
-
Checks for generators that use contextmanagers that don't handle cleanup properly. Is meant to raise visibilty on the case that a generator is not fully exhausted and the contextmanager is not cleaned up properly. A contextmanager must yield a non-constant value and not handle cleanup for GeneratorExit. The using generator must attempt to use the yielded context value
with x() as yand not justwith x().Closes #2832
False Negatives Fixed
-
If and Try nodes are now checked for useless return statements as well.
Closes #9449.
-
Fix false negative for
property-with-parametersin the case of parameters which arepositional-only,keyword-only,variadic positionalorvariadic keyword.Closes #9584
False Positives Fixed
Performance Improvements
-
Ignored modules are now not checked at all, instead of being checked and then ignored. This should speed up the analysis of large codebases which have ignored modules.
Closes #9442
-
ImportChecker's logic has been modified to avoid context files when possible. This makes it possible to cache module searches on astroid and reduce execution times.
Refs #9310.
-
An internal check for
trailing-comma-tuplebeing enabled for a file or not is now done once per file instead of once for each token.Refs #9608.
v3.1.1
What's new in Pylint 3.1.1?
Release date: 2024-05-13
False Positives Fixed
-
Treat
attrs.defineandattrs.frozenas dataclass decorators intoo-few-public-methodscheck.Closes #9345
-
Fix a false positive with
singledispatchmethod-functionwhen a method is decorated with bothfunctools.singledispatchmethodandstaticmethod.Closes #9531
-
Fix a false positive for
consider-using-dict-itemswhen iterating usingkeys()and then deleting an item using the key as a lookup.Closes #9554
v3.1.0
Two new checks--use-yield-from, deprecated-attribute-- and a smattering of bug fixes.
New Features
-
Skip
consider-using-joincheck for non-empty separators if ansuggest-join-with-non-empty-separatoroption is set tono.Closes #8701
-
Discover
.pyifiles when linting.These can be ignored with the
ignore-patternssetting.Closes #9097
-
Check
TypeAliasandTypeVar(PEP 695) nodes forinvalid-name.Refs #9196
-
Support for resolving external toml files named pylintrc.toml and .pylintrc.toml.
Closes #9228
-
Check for
.clear,.discard,.popandremovemethods being called on a set while it is being iterated over.Closes #9334
New Checks
-
New message
use-yield-fromadded to the refactoring checker. This message is emitted when yielding from a loop can be replaced byyield from.Closes #9229.
-
Added a
deprecated-attributemessage to check deprecated attributes in the stdlib.Closes #8855
False Positives Fixed
-
Fixed false positive for
inherit-non-classfor generic Protocols.Closes #9106
-
Exempt
TypedDictfromtyping_extensionsfromtoo-many-ancestorchecks.Refs #9167
False Negatives Fixed
-
Extend broad-exception-raised and broad-exception-caught to except*.
Closes #8827
-
Fix a false-negative for unnecessary if blocks using a different than expected ordering of arguments.
Closes #8947.
Other Bug Fixes
-
Improve the message provided for wrong-import-order check. Instead of the import statement ("import x"), the message now specifies the import that is out of order and which imports should come after it. As reported in the issue, this is particularly helpful if there are multiple imports on a single line that do not follow the PEP8 convention.
The message will report imports as follows: For "import X", it will report "(standard/third party/first party/local) import X" For "import X.Y" and "from X import Y", it will report "(standard/third party/first party/local) import X.Y" The import category is specified to provide explanation as to why pylint has issued the message and guidence to the developer on how to fix the problem.
Closes #8808
Other Changes
-
Print how many files were checked in verbose mode.
Closes #8935
-
Fix a crash when an enum class which is also decorated with a
dataclasses.dataclassdecorator is defined.Closes #9100
Internal Changes
-
Update astroid version to 3.1.0.
Refs #9457
v3.0.4
False Positives Fixed
-
used-before-assignmentis no longer emitted when using a name in a loop and depending on an earlier name assignment in anexceptblock paired withelse: continue.Closes #6804
-
Avoid false positives for
no-memberinvolving function attributes supplied by decorators.Closes #9246
-
Fixed false positive nested-min-max for nested lists.
Closes #9307
-
Fix false positive for
used-before-assignmentin afinallyblock when assignments took place in both thetryblock and each exception handler.Closes #9451
Other Bug Fixes
-
Catch incorrect ValueError
"generator already executing"for Python 3.12.0 - 3.12.2. This is fixed upstream in Python 3.12.3.Closes #9138
v3.0.3
What's new in Pylint 3.0.3?
Release date: 2023-12-11
False Positives Fixed
-
Fixed false positive for
unnecessary-lambdawhen the call has keyword arguments but not the lambda.Closes #9148
-
Fixed incorrect suggestion for shallow copy in unnecessary-comprehension
Example of the suggestion: #pylint: disable=missing-module-docstring a = [1, 2, 3] b = [x for x in a] b[0] = 0 print(a) # [1, 2, 3]
After changing b = [x for x in a] to b = a based on the suggestion, the script now prints [0, 2, 3]. The correct suggestion should be use list(a) to preserve the original behavior.
Closes #9172
-
Fix false positives for
undefined-variableandunused-argumentfor classes and functions using Python 3.12 generic type syntax.Closes #9193
-
Fixed
pointless-string-statementfalse positive for docstrings on Python 3.12 type aliases.Closes #9268
-
Fix false positive for
invalid-exception-operationwhen concatenating tuples of exception types.Closes #9288
Other Bug Fixes
-
Fix a bug where pylint was unable to walk recursively through a directory if the directory has an
__init__.pyfile.Closes #9210
v3.0.2
False Positives Fixed
-
Fix
used-before-assignmentfalse positive for generic type syntax (PEP 695, Python 3.12).Closes #9110
Other Bug Fixes
-
Escape special symbols and newlines in messages.
Closes #7874
-
Fixes suggestion for
nested-min-maxfor expressions with additive operators, list and dict comprehensions.Closes #8524
-
Fixes ignoring conditional imports with
ignore-imports=y.Closes #8914
-
Emit
inconsistent-quotesfor f-strings with 3.12 interpreter only if targeting pre-3.12 versions.Closes #9113
v3.0.1
False Positives Fixed
-
Fixed false positive for
inherit-non-classfor generic Protocols.Closes #9106
Other Changes
-
Fix a crash when an enum class which is also decorated with a
dataclasses.dataclassdecorator is defined.Closes #9100
v3.0.0
Pylint now support python 3.12 officially.
This long anticipated major version also provides some important usability and performance improvements, along with enacting necessary breaking changes and long-announced deprecations. The documentation of each message with an example is very close too.
The required astroid version is now 3.0.0. See the astroid changelog for additional fixes, features, and performance improvements applicable to pylint.
Our code is now fully typed. The invalid-name message no longer checks for a minimum length of 3 characters by default. Dependencies like wrapt or setuptools were removed.
A new json2 reporter has been added. It features an enriched output that is easier to parse and provides more info, here's a sample output.
{
"messages": [
{
"type": "convention",
"symbol": "line-too-long",
"message": "Line too long (1/2)",
"messageId": "C0301",
"confidence": "HIGH",
"module": "0123",
"obj": "",
"line": 1,
"column": 0,
"endLine": 1,
"endColumn": 4,
"path": "0123",
"absolutePath": "0123"
}
],
"statistics": {
"messageTypeCount": {
"fatal": 0,
"error": 0,
"warning": 0,
"refactor": 0,
"convention": 1,
"info": 0
},
"modulesLinted": 1,
"score": 5.0
}
}
Breaking Changes
-
Enabling or disabling individual messages will now take effect even if an
--enable=allordisable=allfollows in the same configuration file (or on the command line).This means for the following example,
fixmemessages will now be emitted:pylint my_module --enable=fixme --disable=allTo regain the prior behavior, remove the superfluous earlier option.
Closes #3696
-
Remove support for launching pylint with Python 3.7. Code that supports Python 3.7 can still be linted with the
--py-version=3.7setting.Refs #6306
-
Disables placed in a
tryblock now apply to theexceptblock. Previously, they only happened to do so in the presence of anelseclause.Refs #7767
-
pyreversenow uses a new default color palette that is more colorblind friendly. The color scheme is taken fromPaul Tol's Notes <https://personal.sron.nl/~pault/>_. If you prefer other colors, you can use the--color-paletteoption to specify custom colors.Closes #8251
-
Everything related to the
__implements__construct was removed. It was based on PEP245 that was proposed in 2001 and rejected in 2006.The capability from pyreverse to take
__implements__into account when generating diagrams was also removed.Refs #8404
-
pyreverse: Support for the.vcgoutput format (Visualization of Compiler Graphs) has been dropped.Closes #8416
-
The warning when the now useless old pylint cache directory (pylint.d) was found was removed. The cache dir is documented in
the FAQ <https://pylint.readthedocs.io/en/latest/faq.html#where-is-the-persistent-data-stored-to-compare-between-successive-runs>_.Refs #8462
-
Following a deprecation period,
pylint.config.PYLINTRCwas removed. Use thepylint.config.find_default_config_filesgenerator instead.Closes #8862
Changes requiring user actions
-
The
invalid-namemessage no longer checks for a minimum length of 3 characters by default. (This was an unadvertised commingling of concerns between casing and name length, and users regularly reported this to be surprising.)If checking for a minimum length is still desired, it can be regained in two ways:
-
If you are content with a
disallowed-namemessage (instead ofinvalid-name), then simply add the optionbad-names-rgxs="^..?$", which will fail 1-2 character-long names. (Ensure you enabledisallowed-name.) -
If you would prefer an
invalid-namemessage to be emitted, or would prefer finer-grained control over the circumstances in which messages are emitted (classes vs. methods, etc.), then avail yourself of the regex options describedhere <https://pylint.readthedocs.io/en/stable/user_guide/configuration/all-options.html#main-checker>. (In particular, take note of the commented out options in the "example configuration" given at the bottom of the section.) The prior regexes can be found in thepull request <https://github.com/pylint-dev/pylint/pull/8813>that removed the length requirements.
Closes #2018
-
-
The compare to empty string checker (
pylint.extensions.emptystring) and the compare to zero checker (pylint.extensions.compare-to-zero) have been removed and their checks are now part of the implicit booleaness checker:-
compare-to-zerowas renameduse-implicit-booleaness-not-comparison-to-zeroandcompare-to-empty-stringwas renameduse-implicit-booleaness-not-comparison-to-stringand they now need to be enabled explicitly. -
The
pylint.extensions.emptystringandpylint.extensions.compare-to-zeroextensions no longer exist and need to be removed from theload-pluginsoption. -
Messages related to implicit booleaness were made more explicit and actionable. This permits to make their likeness explicit and will provide better performance as they share most of their conditions to be raised.
Closes #6871
-
-
epylint was removed. It now lives at: https://github.com/emacsorphanage/pylint.
Refs #7737
-
The
overgeneral-exceptionsoption now only takes fully qualified names into account (builtins.ExceptionnotException). If you overrode this option, you need to use the fully qualified name now.There's still a warning, but it will be removed in 3.1.0.
Refs #8411
-
Following a deprecation period, it's no longer possible to use
MASTERormasteras configuration section insetup.cfgortox.ini. It's bad practice to not start a section title with the tool name. Please usepylint.maininstead.Refs #8465
-
Package stats are now printed when running Pyreverse and a
--verboseflag was added to get the original output with parsed modules. You might need to activate the verbose option if you want to keep the old output.Closes #8973
New Features
-
A new
json2reporter has been added. It features a more enriched output that is easier to parse and provides more info.Compared to
jsonthe only changes are that messages are now under the"messages"key and that"message-id"now follows the camelCase convention and is renamed to"messageId". The new reporter also reports the "score" of the modules you linted as defined by theevaluationoption and provides statistics about the modules you linted.We encourage users to use the new reporter as the
jsonreporter will no longer be maintained.Closes #4741
-
In Pyreverse package dependency diagrams, show when a module imports another only for type-checking.
Closes #8112
-
Add new option (
--show-stdlib,-L) topyreverse. This is similar to the behavior of--show-builtinin that standard library modules are now not included by default, and this option will include them.Closes #8181
-
Add Pyreverse option to exclude standalone nodes from diagrams with
--no-standalone.Closes #8476
New Checks
-
Added
DataclassCheckermodule andinvalid-field-callchecker to check for invalid dataclasses.field() usage.Refs #5159
-
Add
return-in-finallyto emit a message if a return statement was found in a finally clause.Closes #8260
-
Add a new checker
kwarg-superseded-by-positional-argto warn when a function is called with a keyword argument which shares a name with a positional-only parameter and the function contains a keyword variadic parameter dictionary. It may be surprising behaviour when the keyword argument is added to the keyword variadic parameter dictionary.Closes #8558
Extensions
-
Add new
prefer-typing-namedtuplemessage to theCodeStyleCheckerto suggest rewriting calls tocollections.namedtupleas classes inheriting fromtyping.NamedTupleon Python 3.6+.Requires
load-plugins=pylint.extensions.code_styleandenable=prefer-typing-namedtupleto be raised.Closes #8660
False Positives Fixed
-
Extend concept of "function ambiguity" in
safe_infer()from differing number of function arguments to differing set of argument names.Solves false positives in
tensorflow.Closes #3613
-
Fix
unused-argumentfalse positive when__new__does not use all the arguments of__init__.Closes #3670
-
Fix a false positive for
invalid-namewhen a type-annotated class variable in anenum.Enumclass has no assigned value.Refs #7402
-
Fix
unused-importfalse positive for usage ofsix.with_metaclass.Closes #7506
-
Fix false negatives and false positives for
too-many-try-statements,too-complex, andtoo-many-branchesby correctly counting statements under atry.Refs #7767
-
When checking for unbalanced dict unpacking in for-loops, Pylint will now test whether the length of each value to be unpacked matches the number of unpacking targets. Previously, Pylint would test the number of values for the loop iteration, which would produce a false unbalanced-dict-unpacking warning.
Closes #8156
-
Fix false positive for
used-before-assignmentwhen usage and assignment are guarded by the same test in different statements.Closes #8167
-
Adds
asyncSetUpto the defaultdefining-attr-methodslist to silenceattribute-defined-outside-initwarning when usingunittest.IsolatedAsyncioTestCase.Refs #8403
-
logging-not-lazyis not longer emitted for explicitly concatenated string arguments.Closes #8410
-
Fix false positive for isinstance-second-argument-not-valid-type when union types contains None.
Closes #8424
-
invalid-namenow allows for integers intypealiasnames:- now valid:
Good2Name,GoodName2. - still invalid:
_1BadName.
Closes #8485
- now valid:
-
No longer consider
Unionas type annotation as type alias for naming checks.Closes #8487
-
unnecessary-lambdano longer warns on lambdas which use its parameters in their body (other than the final arguments), e.g.lambda foo: (bar if foo else baz)(foo).Closes #8496
-
Fixed
unused-importso that it observes thedummy-variables-rgxoption.Closes #8500
-
Uniontyped variables without assignment are no longer treated asTypeAlias.Closes #8540
-
Allow parenthesized implicitly concatenated strings when
check-str-concat-over-line-jumpsis enabled.Closes #8552.
-
Fix false positive for
positional-only-arguments-expectedwhen a function contains both a positional-only parameter that has a default value, and**kwargs.Closes #8555
-
Fix false positive for
keyword-arg-before-varargwhen a positional-only parameter with a default value precedes*args.Closes #8570
-
Fix false positive for
arguments-differwhen overriding__init_subclass__.Closes #8919
-
Fix a false positive for
no-value-for-parameterwhen a staticmethod is called in a class body.Closes #9036
False Negatives Fixed
-
Emit
used-before-assignmentwhen calling module-level functions before definition.Closes #1144
-
Apply
infer_kwarg_from_call()to more checksThese mostly solve false negatives for various checks, save for one false positive for
use-maxsplit-arg.Closes #7761
-
TypeAliasvariables defined in functions are now checked forinvalid-nameerrors.Closes #8536
-
Fix false negative for
no-value-for-parameterwhen a function, whose signature contains both a positional-only parameternameand also*kwargs, is called with a keyword-argument forname.Closes #8559
-
Fix a false negative for
too-many-argumentsby considering positional-only and keyword-only parameters.Closes #8667
-
Emit
assignment-from-no-returnfor calls to builtin methods likedict.update(). Calls tolist.sort()now raiseassignment-from-no-returnrather thanassignment-from-nonefor consistency. -
consider-using-augmented-assignis now applied to dicts and lists as well.Closes #8959
Other Bug Fixes
-
Support
duplicate-codemessage when parallelizing with--jobs.Closes #374
-
Support
cyclic-importmessage when parallelizing with--jobs.Closes #4171
-
--jobscan now be used with--load-plugins.This had regressed in astroid 2.5.0.
Closes #4874
-
docparams extension considers type comments as type documentation.
Closes #6287
-
When parsing comma-separated lists of regular expressions in the config, ignore commas that are inside braces since those indicate quantifiers, not delineation between expressions.
Closes #7229
-
The
ignored-modulesoption will now be correctly taken into account forno-name-in-module.Closes #7578
-
sys.argvis now always correctly considered as impossible to infer (instead of using the actual values given to pylint).Closes #7710
-
Avoid duplicative warnings for unqualified exception names in the
overgeneral-exceptionssetting when running with--jobs.Closes #7774
-
Don't show class fields more than once in Pyreverse diagrams.
Closes #8189
-
Fix
used-before-assignmentfalse negative when TYPE_CHECKING imports are used in multiple scopes.Closes #8198
-
--clear-cache-post-runnow also clears LRU caches for pylint utilities holding references to AST nodes.Closes #8361
-
Fix a crash when
TYPE_CHECKINGis used without importing it.Closes #8434
-
Fix a
used-before-assignmentfalse positive when imports are made under theTYPE_CHECKINGelse if branch.Closes #8437
-
Fix a regression of
preferred-moduleswhere a partial match was used instead of the required full match.Closes #8453
-
Fix a crash in pyreverse when "/" characters are used in the output filename e.g pyreverse -o png -p name/ path/to/project.
Closes #8504
-
Don't show arrows more than once in Pyreverse diagrams.
Closes #8522
-
Improve output of
consider-using-generatormessage formin()calls withdefaultkeyword.Closes #8563
-
Fixed a crash when generating a configuration file:
tomlkit.exceptions.TOMLKitError: Can't add a table to a dotted keycaused by tomlkitv0.11.8.Closes #8632
-
Fix a line break error in Pyreverse dot output.
Closes #8671
-
Fix a false positive for
method-hiddenwhen usingcached_propertydecorator.Closes #8753
-
Dunder methods defined in lambda do not trigger
unnecessary-dunder-callanymore, if they cannot be replaced by the non-dunder call.Closes #8769
-
Don't show duplicate type annotations in Pyreverse diagrams.
Closes #8888
-
Fixing inconsistent hashing issue in
BaseCheckercausing some reports not being exported.Closes #9001
-
Don't add
Optionalto|annotations withNonein Pyreverse diagrams.Closes #9014
-
Pyreverse doesn't show multiple class association arrows anymore, but only the strongest one.
Refs #9045
-
Prevented data loss in the linter stats for messages relating to the linter itself (e.g.
unknown-option-value), fixing problems with score, fail-on, etc.Closes #9059
-
Fix crash in refactoring checker when unary operand used with variable in for loop.
Closes #9074
Other Changes
-
Pylint now exposes its type annotations.
-
Search for
pyproject.tomlrecursively in parent directories up to a project or file system root. -
All code related to the optparse config parsing has been removed.
Refs #8405
-
Pylint now supports python 3.12.
Refs #8718
-
Add a CITATION.cff file to the root of the repository containing the necessary metadata to cite Pylint.
Closes #8760
-
Renamed the "unneeded-not" error into "unnecessary_negation" to be clearer.
Closes #8789
Internal Changes
-
get_message_definitionwas removed from the base checker API. You can access message definitions through theMessageStore.Refs #8401
-
Everything related to the
__implements__construct was removed. It was based on PEP245 that was proposed in 2001 and rejected in 2006.All the classes inheriting
Interfaceinpylint.interfaceswere removed.Checkershould only inheritBaseCheckeror any of the other checker types frompylint.checkers.Reportershould only inheritBaseReporter.Refs #8404
-
modnameandmsg_storeare now required to be given inFileState.collect_block_lineshas also been removed.Pylinter.current_namecannot be null anymore.Refs #8407
-
Reporter.set_outputwas removed in favor ofreporter.out = stream.Refs #8408
-
A number of old utility functions and classes have been removed:
MapReduceMixin: To make a checker reduce map data simply implementget_map_dataandreduce_map_data.is_inside_lambda: Useutils.get_node_first_ancestor_of_type(x, nodes.Lambda)check_messages: Useutils.only_required_for_messagesis_class_subscriptable_pep585_with_postponed_evaluation_enabled: Useis_postponed_evaluation_enabled(node)andis_node_in_type_annotation_context(node)get_python_path: assumption that there's always an init.py is not true since python 3.3 and is causing problems, particularly with PEP 420. Usediscover_package_pathand pass source root(s).fix_import_path: Useaugmented_sys_pathand pass additionalsys.pathentries as an argument obtained fromdiscover_package_path.get_global_option: Usechecker.linter.configto get all global options.Related private objects have been removed as well.
Refs #8409
-
colorize_ansinow only accepts aMessageStyleobject.Refs #8412
-
Following a deprecation period,
Pylinter.checknow only works with sequences of strings, not strings.Refs #8463
-
Following a deprecation period,
ColorizedTextReporteronly acceptsColorMappingDict.Refs #8464
-
Following a deprecation period,
MessageTest'send_lineandend_col_offsetmust be accurate in functional tests (for python 3.8 or above on cpython, and for python 3.9 or superior on pypy).Refs #8466
-
Following a deprecation period, the
do_exitargument of theRunclass (and of the_Runclass in testutils) were removed.Refs #8472
-
Following a deprecation period, the
py_versionargument of theMessageDefinition.may_be_emittedfunction is now required. The most likely solution is to use 'linter.config.py_version' if you need to keep using this function, or to use 'MessageDefinition.is_message_enabled' instead.Refs #8473
-
Following a deprecation period, the
OutputLineclass now requires the right number of argument all the time. The functional output can be regenerated automatically to achieve that easily.Refs #8474
-
Following a deprecation period,
is_typing_guard,is_node_in_typing_guarded_import_blockandis_node_in_guarded_import_blockfrompylint.utilswere removed: use a combination ofis_sys_guardandin_type_checking_blockinstead.Refs #8475
-
Following a deprecation period, the
locationargument of theMessageclass must now be aMessageLocationTuple.Refs #8477
-
Following a deprecation period, the
check_single_filefunction of thePylinteris replaced byPylinter.check_single_file_item.Refs #8478
Performance Improvements
-
pylintruns (at least) ~5% faster after improvements toastroidthat make better use of the inference cache. -
- Optimize
is_trailing_comma(). - Cache
class_is_abstract().
Refs #1954
- Optimize
-
Exit immediately if all messages are disabled.
Closes #8715
v2.17.7
2.17.7 is the last release before we only support pylint 3.0.0 or superior and python 3.8 or superior.
False Positives Fixed
-
Fix a regression in pylint 2.17.6 / astroid 2.15.7 causing various messages for code involving
TypeVar.Closes #9069
Other Bug Fixes
-
Fix crash in refactoring checker when unary operand used with variable in for loop.
Closes #9074
v2.17.6
Other Bug Fixes
-
When parsing comma-separated lists of regular expressions in the config, ignore commas that are inside braces since those indicate quantifiers, not delineation between expressions.
Closes #7229
-
sys.argvis now always correctly considered as impossible to infer (instead of using the actual values given to pylint).Closes #9047
-
Don't show class fields more than once in Pyreverse diagrams.
Closes #8189
-
Don't show arrows more than once in Pyreverse diagrams.
Closes #8522
-
Don't show duplicate type annotations in Pyreverse diagrams.
Closes #8888
-
Don't add
Optionalto|annotations withNonein Pyreverse diagrams.Closes #9014
v2.17.5
What's new in Pylint 2.17.5?
Release date: 2023-07-26
False Positives Fixed
-
Fix a false positive for
unused-variablewhen there is an import in aif TYPE_CHECKING:block andallow-global-unused-variablesis set tonoin the configuration.Closes #8696
-
Fix false positives generated when supplying arguments as
**kwargsto IO calls like open().Closes #8719
-
Fix a false positive where pylint was ignoring method calls annotated as
NoReturnduring theinconsistent-return-statementscheck.Closes #8747
-
Exempt parents with only type annotations from the
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR was generated by Mend Renovate. View the repository job log.
See https://github.com/OSGeo/grass/issues/3921 on what is needed before being able to change to versions higher that the one we use.
Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
⚠️ Warning: custom changes will be lost.
I've finally managed to get something, a great start. There's more rules checked, but for now, to allow just running, some rules that were always checked might be disabled for now.
Since Pylint doesn't have an exclusion mechanism, and I didn't set up a custom plugin to do that (since without the plugin, running locally doesn't work unless you also install that plugin), I just ignored all the rules that had violations.
So, we end up like when we introduced ruff, with a list of rules to solve and enable.
Configuring an ignore plugin (if the ones that exist work with recent pylint versions), we could do it later, and exclude rules only for a subset of paths instead of everywhere, reducing what is excluded.
A future issue, that I avoid here, is that there is more rules checked now, and some take way more time on our repo as before. For example, the similarity checks seemed really slow. Inside a docker container in windows, even when giving more cores, running locally is sooooo much longer (in some cases only), than on linux CI, even when CI has less cores (or that I reduce the cores given to the docker container). So evaluating the time taken is a bit harder.