grass icon indicating copy to clipboard operation
grass copied to clipboard

[Feat] Remove version from executable on Windows

Open wenzeslaus opened this issue 1 year ago • 6 comments

Suggestion

Remove version numbers from the bat file which starts GRASS GIS on Winodws.

Background

In PR #1597 for 8.0 we removed version from the executable. While this was smooth for Linux (and others?), it didn't work on Windows due to issues with Python imports. While this still waits on being resolved, I think we may have went too far in keeping the version even for the bat script, while keeping it for Python script is likely enough to work around the import issue.

Compatibility

While this may break a system which automatically adds the version numbers. However, any code needs an update when the version is there explicitly, so this time the update will be not (just) the numbers, but changing the executable name.

Possible backwards compatible solution would be to add a version-less bat script which calls the versioned one (or vice versa). Alternatively, a copy of the bat file can be created.

wenzeslaus avatar Jun 11 '24 00:06 wenzeslaus

at least, it may work for the standalone installer.

it may not work for OSGeo4W environment, as it is possible there are more than one GRASS versions installed.

C:\OSGeo4W\apps\grass>dir /b
grass83
grass85
C:\OSGeo4W\bin>dir /b | findstr grass
grass83.bat
grass85.bat
python-grass83.bat
python-grass85.bat

hellik avatar Jun 15 '24 12:06 hellik

it may not work for OSGeo4W environment, as it is possible there are more than one GRASS versions installed.

Shouldn't there be a default version which has a version-less alias?

How other software in OSGeo does that?

wenzeslaus avatar Jun 15 '24 19:06 wenzeslaus

it may not work for OSGeo4W environment, as it is possible there are more than one GRASS versions installed.

Shouldn't there be a default version which has a version-less alias?

How other software in OSGeo does that?

looking at http://download.osgeo.org/osgeo4w/v2/x86_64/release/qgis/

qgis
qgis-dev
qgis-ltr

hellik avatar Jun 16 '24 08:06 hellik

Is there like gdalinfo3.8 and gdalinfo3.9?

wenzeslaus avatar Jun 16 '24 12:06 wenzeslaus

Is there like gdalinfo3.8 and gdalinfo3.9?

no

C:\OSGeo4W\bin>dir /b | findstr gdal
gdal-config
gdal309.dll
gdaladdo.exe
gdalbuildvrt.exe
gdaldem.exe
gdalenhance.exe
gdalinfo.exe
gdallocationinfo.exe
gdalmanage.exe
gdalmdiminfo.exe
gdalmdimtranslate.exe
gdalsrsinfo.exe
gdaltindex.exe
gdaltransform.exe
gdalwarp.exe
gdal_contour.exe
gdal_create.exe
gdal_footprint.exe
gdal_grid.exe
gdal_rasterize.exe
gdal_translate.exe
gdal_viewshed.exe



hellik avatar Jun 16 '24 12:06 hellik

C:\OSGeo4W\apps>dir /b
gdal
grass
gs
openssl
Python312
qgis
Qt5

hellik avatar Jun 16 '24 12:06 hellik