grass icon indicating copy to clipboard operation
grass copied to clipboard

[Bug] Docker builds don't seem successful

Open echoix opened this issue 2 years ago • 2 comments

Describe the bug I'm trying to debug something and tried using Docker to run some steps after the build. I observed that for the ubuntu without gui, the end of compilation message doesn't appear as expected, even though the build doesn't exit as failed, it continues to a next step. I get some message like:

#17 144.8 WARNING: Some addons failed when loading. Please consider to update your addons by running 'g.extension.all -f'.
#17 144.9 Traceback (most recent call last):
#17 144.9   File "/src/grass_build/gui/wxpython/core/menutree.py", line 41, in <module>
#17 144.9     import wx
#17 144.9 ModuleNotFoundError: No module named 'wx'
#17 144.9 make[4]: *** [Makefile:53: menustrings.py] Error 1
#17 144.9 make[3]: [Makefile:35: default] Error 2 (ignored)

I went to see the latest dockers builds on main, and 3 out of 4 seem to stop after that 'wx' message, and even the one with GUI doesn't show the end of compilation message, but runs longer.

To Reproduce I won't explain how to make a docker build, but this is also highlighted in our current CI

Steps to reproduce the behavior:

  1. Ubuntu no gui : https://github.com/OSGeo/grass/actions/runs/7767117232/job/21183616894#step:7:12784
  2. Alpine: https://github.com/OSGeo/grass/actions/runs/7767117232/job/21183616550#step:7:9542
  3. Debian : https://github.com/OSGeo/grass/actions/runs/7767117232/job/21183616688#step:7:13677
  4. Ubuntu Gui: either before translations https://github.com/OSGeo/grass/actions/runs/7767117232/job/21183617139#step:7:13863 or after translations https://github.com/OSGeo/grass/actions/runs/7767117232/job/21183617139#step:7:13957

Expected behavior I expect the compilation to finish with a message like https://github.com/OSGeo/grass/actions/runs/7767117237/job/21183617659#step:10:12787 image

Screenshots If applicable, add screenshots to help explain your problem.

Ubuntu without gui image

Ubuntu with gui: image image

Our normal ubuntu builds finish with image

System description (please complete the following information):

  • Operating System: Linux docker
  • GRASS GIS version: main 2024-02-03 https://github.com/OSGeo/grass/commit/89cf288f4f790d85459c9e2aa8e07ed832746610

Additional context

This isn't specific to a commit. I'm not sure with all those warnings if the test suite would run correctly. The semicolons after the configure/make/make install are unexpected for me. That would mean that files are copied whatever the exit code of the previous command was, and could set a sucessful exit code anyways.

echoix avatar Feb 03 '24 15:02 echoix

See also #588 for the same report and related discussion.

Apparently python3-wxpython4 solved it for some distro(s).

neteler avatar Feb 04 '24 18:02 neteler

Ok, that's a possible explanation for the 3 non gui ones, but what about the gui build? It doesn't have that error, but doesn't seem to reach the end of compilation message. Are the log entries redirected differently when building the Dockerfile?

echoix avatar Feb 04 '24 18:02 echoix