grass icon indicating copy to clipboard operation
grass copied to clipboard

wxGUI/preferences: allow the user save/load single-window mode panes layout

Open tmszi opened this issue 1 year ago • 4 comments

Allow the user save/load single-window mode panes layout.

Closes #3212, #3210.

https://github.com/OSGeo/grass/assets/50632337/08e206b2-76f9-42d9-8009-49e68f2e4b2e

tmszi avatar Dec 22 '23 07:12 tmszi

I have tested it and it works well :-)

I am just thinking about the placement of the new check box because it is actually not the content of Workspace settings. Maybe we could create a new Layout settings static box and place there things related to the Layout?

Suggestion: Layout settings ------------------------

* Save current window layout as default

* Save current single window panes layout as default

* Hide 'Tools' tab

* Hide 'History' tab

* Hide 'Python' tab

We might also disable or completely toss out the three "Hide" checkboxes for Single-Window case. I think it is not of any use when there is the new "Save current single window panes layout as default" checkbox. What do you think @tmszi, @petrasovaa ?

Another (simpler) variant coming to my mind, dealing just with this new checkbox, could be to place the new checkbox in the Appearance tab under the Window layout settings static box and enable it only when Use single-window mode is checked.

But probably for the future, a rearrangement of the checkboxes I mentioned earlier would be needed anyway..

lindakarlovska avatar Dec 25 '23 15:12 lindakarlovska

I am just thinking about the placement of the new check box because it is actually not the content of Workspace settings. Maybe we could create a new Layout settings static box and place there things related to the Layout?

Suggestion: Layout settings ------------------------

* Save current window layout as default

* Save current single window panes layout as default

* Hide 'Tools' tab

* Hide 'History' tab

* Hide 'Python' tab

I agree with your suggestion.

We might also disable or completely toss out the three "Hide" checkboxes for Single-Window case. I think it is not of any use when there is the new "Save current single window panes layout as default" checkbox.

Maybe I would leave these three "Hide" checkboxes for single-window mode as well, because they are valid (minimize vs hide).

tmszi avatar Dec 25 '23 16:12 tmszi

Layout settings:

wxgui_preferences_layout_settings

tmszi avatar Jan 13 '24 18:01 tmszi

Layout settings:

wxgui_preferences_layout_settings

Looks great! Thanks @tmszi for changes.

lindakarlovska avatar Jan 13 '24 20:01 lindakarlovska