grass icon indicating copy to clipboard operation
grass copied to clipboard

[Feat] Remove message about creating temporal database

Open wenzeslaus opened this issue 2 years ago • 1 comments

Is your feature request related to a problem? Please describe.

Running a temporal module in a new mapset (subproject) creates a temporal SQLite database according to the default settings. As far as I can tell, that's the same thing which happens for the shared SQLite database for vector attributes. Hence, there seems to be no need for any message about that.

What happens now is that the following is printed:

Default TGIS driver / database set to:
driver: sqlite
database: $GISDBASE/$LOCATION_NAME/$MAPSET/tgis/sqlite.db
WARNING: Temporal database connection defined as:
/share/mitasova/vpetras/post-install-tests/nc_spm_full_v2alpha2/__temporal_t_rast_algebra_test_raster_algebra_granularity_n2e4_13_4765/tgis/sqlite.db
But database file does not exist.
Creating temporal database: /share/mitasova/vpetras/post-install-tests/nc_spm_full_v2alpha2/__temporal_t_rast_algebra_test_raster_algebra_granularity_n2e4_13_4765/tgis/sqlite.db

The warning even overstates the seriousness of the issue and the message is repetitive, but I think no message is needed at all.

Describe the solution you'd like

No message for expected behavior of something which happens automatically in the background.

Describe alternatives you've considered

Removing warning and making the message more concise would help, but even that message still seems like a best fit for verbose.

Additional context

This seems to be an issue for beginners (confusion) and scripting with temporary mapsets (a lot of unnecessary output).

wenzeslaus avatar Nov 08 '22 18:11 wenzeslaus

I agree that the warning part can be omitted, I'd leave it like:

Default TGIS driver / database set to:
driver: sqlite
database: $GISDBASE/$LOCATION_NAME/$MAPSET/tgis/sqlite.db
Creating temporal database: /share/mitasova/vpetras/post-install-tests/nc_spm_full_v2alpha2/__temporal_t_rast_algebra_test_raster_algebra_granularity_n2e4_13_4765/tgis/sqlite.db

and move it to verbose flag.

veroandreo avatar Nov 14 '22 11:11 veroandreo