grass
grass copied to clipboard
wxGUI/psmap: fix show correct error message if Ghostscript isn't installed (required for rendering output PDF file) on the OS MS Windows platform
Describe the bug Wrong error message if Ghostscript gswin32c/gswin64c isn't installed (required for rendering output PDF file) on the OS MS Windows platform
To Reproduce Steps to reproduce the behavior:
- Download and install e.g. WinGRASS-8.3.dev
- Launch wxGUI Cartographic Composer
g.gui.psmap
- Add Map frame and choose some raster map e.g. elevation
- Push toolbar Generate PDF output tool
- See error
Expected behavior If Ghostscript gswin32c/gswin64c isn't installed (required for rendering output PDF file), show correct error message.
System description:
- Operating System: MS Windows
- GRASS GIS version: all versions
All right, I fixed it.
All right, I fixed it.
I apologize, looking at it again, I gave you a wrong suggestion, the translation doesn't work with f-strings so you will need to use a format function as before:
_(xxxx {yyyy} xxx).format(...)
All right, I fixed it.
I apologize, looking at it again, I gave you a wrong suggestion, the translation doesn't work with f-strings so you will need to use a format function as before:
_(xxxx {yyyy} xxx).format(...)
Okay, I fixed it.
@petrasovaa Maybe should be better use HyperlinkDialog
if Ghostscript is not available (for rendering PDF), same as in PR #2421 (for rendering preview) with same simplified error message?
@petrasovaa Maybe should be better use
HyperlinkDialog
if Ghostscript is not available (for rendering PDF), same as in PR #2421 (for rendering preview) with same simplified error message?
I agree, but I will leave it up to you if you want to change that.
Rebase https://github.com/OSGeo/grass/commit/7540bf12c111065977cdae2c0e3947ec9175c8d0 plus replace GError
dialog with HyperlinkDialog
.