grass icon indicating copy to clipboard operation
grass copied to clipboard

Published 20 hours ago • verified publisher icon OSGeo

[Feat] r.surf.* need seed parameter for reproducibility

Open petrasovaa opened this issue 4 years ago • 10 comments

Modules r.surf.random, r.surf.gauss, r.surf.fractal generate different results every time you run them. They need seed parameter for reproducible results, similarly to r.mapcalc.

petrasovaa avatar Oct 23 '20 19:10 petrasovaa

Hi @petrasovaa i'm looking forward for working on Adding JSON output project as part of GSoC ,can i work on this issue ?

istutea avatar Feb 28 '24 20:02 istutea

Hi @petrasovaa i'm looking forward for working on Adding JSON output project as part of GSoC ,can i work on this issue ?

Welcome! Yes, I suggest to work on r.surf.fractal, look at how r.mapcalc or r.random deal with it using seed parameter and -s flag. Ideally please also include a test. Let us know if you have questions.

petrasovaa avatar Feb 28 '24 20:02 petrasovaa

Hi @petrasovaa , I am Shashank Shekhar Singh a sophomore from IIT BHU, India. I have developed interest in this project and want to contribute to Add JSON output to different tools in C as my GSOC Project this year. Hope we can discuss further procedures for the same.

Shashankss1205 avatar Mar 09 '24 20:03 Shashankss1205

Hi @petrasovaa i'm looking forward for working on Adding JSON output project as part of GSoC ,can i work on this issue ?

Welcome! Yes, I suggest to work on r.surf.fractal, look at how r.mapcalc or r.random deal with it using seed parameter and -s flag. Ideally please also include a test. Let us know if you have questions.

Hi @petrasovaa, I have written the code for adding seed and -s flag for reproducibility, along with a unit test (please verify it once). I tried sending a PR for the same, but it says Permission denied. Screenshot from 2024-03-10 03-22-06

Can you please help me out !!

Shashankss1205 avatar Mar 09 '24 21:03 Shashankss1205

You are trying to push directly to the OSGeo/grass repo, not your fork. Try using the little cloud with an up arrow in the bottom left corner. It should/might offer you to push that branch in your fork

echoix avatar Mar 09 '24 22:03 echoix

Oh I am extremely sorry for doing this silly mistake here. Sending a forked PR in a moment.

Shashankss1205 avatar Mar 09 '24 22:03 Shashankss1205

Hi @petrasovaa I intend to apply to "Adding JSON output project as part of GSoC" as well but I see a PR is already open for this issue. Should I work on this and open a PR for it anyway? Otherwise, can you please point me to another issue to work on? Thanks.

kritibirda26 avatar Mar 22 '24 09:03 kritibirda26

Hi @petrasovaa I intend to apply to "Adding JSON output project as part of GSoC" as well but I see a PR is already open for this issue. Should I work on this and open a PR for it anyway? Otherwise, can you please point me to another issue to work on? Thanks.

Sure. I would suggest to start working on adding JSON to one of the tools mentioned in #3020. Specifically, I suggest adding JSON to r.what. I created an issue for this: #3518, so we can discuss more there.

petrasovaa avatar Mar 22 '24 13:03 petrasovaa

Hi...... , I want to work on this problem problem statement as a part of GSOC

Jasmitha-Mannam avatar Mar 27 '24 17:03 Jasmitha-Mannam

Hi...... , I want to work on this problem problem statement as a part of GSOC

Hi @Jasmitha-Mannam, we currently don't have anybody else interested in the STAC idea and there are some overlaps with JSON idea, so I wonder if you would be interested in the STAC idea instead? If yes, for a test of skills please try to work on #3537.

petrasovaa avatar Mar 27 '24 17:03 petrasovaa