grass-addons icon indicating copy to clipboard operation
grass-addons copied to clipboard

utils/cronjobs_osgeo_lxd: allow register all addons keywords in main Keywords Index

Open tmszi opened this issue 3 years ago • 1 comments

Implement (closes) #776. Before apply this PR, you have to apply this GRASS GIS PR, please.

tmszi avatar Aug 20 '22 16:08 tmszi

Thanks for implementing it, @tmszi ! I will test asap.

neteler avatar Aug 20 '22 19:08 neteler

I could finally test this, sorry for the delay.

Very nice, we are almost there! E.g.

https://grass.osgeo.org/grass83/manuals/keywords.html#Sentinel --> i.sentinel.* is listed.

The only thing to change is the URL: /var/www/code_and_data/ leaks into it which comes from the usage of a related link on the build server, so:

https://grass.osgeo.org/var/www/code_and_data/grass83/manuals/addons/i.sentinel.coverage.html

should be

https://grass.osgeo.org/grass83/manuals/addons/i.sentinel.coverage.html

(likewise for all other addons).

neteler avatar Sep 08 '22 22:09 neteler

I could finally test this, sorry for the delay.

Very nice, we are almost there! E.g.

https://grass.osgeo.org/grass83/manuals/keywords.html#Sentinel --> i.sentinel.* is listed.

The only thing to change is the URL: /var/www/code_and_data/ leaks into it which comes from the usage of a related link on the build server, so:

https://grass.osgeo.org/var/www/code_and_data/grass83/manuals/addons/i.sentinel.coverage.html

should be

https://grass.osgeo.org/grass83/manuals/addons/i.sentinel.coverage.html

(likewise for all other addons).

Thanks Markus. This commit https://github.com/OSGeo/grass/pull/2529/commits/4fe3a0b1149cb0522d26bf505a0ac605e04a1cef solve it.

addons_man_page_relative_link

tmszi avatar Sep 09 '22 06:09 tmszi

Thanks Markus. This commit OSGeo/grass@4fe3a0b solve it.

Excellent, I have just tested it on the server and it works. @ all: Please have a look if all manual/addon links work.

GRASS GIS 8 manual:

  • main: https://grass.osgeo.org/grass83/manuals/
  • Addons: https://grass.osgeo.org/grass83/manuals/addons/
  • pygrass progman: https://grass.osgeo.org/grass83/manuals/libpython/

neteler avatar Sep 09 '22 07:09 neteler

@tmszi seems a double // leaks in somewhere, only discovered that now.

neteler avatar Sep 09 '22 12:09 neteler

@tmszi seems a double // leaks in somewhere, only discovered that now.

I cleaned up the local server patches, updated and recompiled.

This effect only happens with the "grass-stable" redirects:

https://grass.osgeo.org/grass-stable/manuals/addons/d.vect.colbp.html --> https://grass.osgeo.org/grass82//manuals/addons/d.vect.colbp.html

Probably it is an issue of the Apache redirect (but I think to not have seen it before).

neteler avatar Sep 09 '22 18:09 neteler

@tmszi seems a double // leaks in somewhere, only discovered that now.

I cleaned up the local server patches, updated and recompiled.

This effect only happens with the "grass-stable" redirects:

https://grass.osgeo.org/grass-stable/manuals/addons/d.vect.colbp.html --> https://grass.osgeo.org/grass82//manuals/addons/d.vect.colbp.html

Probably it is an issue of the Apache redirect (but I think to not have seen it before).

I found // in URL here https://grass.osgeo.org/grass82//manuals/index.html

tmszi avatar Sep 09 '22 18:09 tmszi

Could @neteler share Apache config/part of config (if it possible), please?

tmszi avatar Sep 09 '22 19:09 tmszi

Could @neteler share Apache config/part of config (if it possible), please?

Yes - I have sent it to you via personal email.

neteler avatar Sep 09 '22 19:09 neteler

Could @neteler share Apache config/part of config (if it possible), please?

Yes - I have sent it to you via personal email.

Ok. Thanks.

tmszi avatar Sep 09 '22 20:09 tmszi