grass-addons
grass-addons copied to clipboard
OSGeo
r.damflood: Update manual and migrate Italian to English
The changes in this addon were made in a separate PR since they were more important than others.
Before merging, I'd like some attentive feedback from Italian-speaking contributors to validate that the comments have the same meaning. I tried my best to find something that works in the code context.
@rmarzocchi84 would you mind assisting with @echoix translation questions above?? Much appreciated! :)
@rmarzocchi84 would you mind assisting with @echoix translation questions above?? Much appreciated! :)
I will finish the review tomorrow! Many thanks for your work @echoix really appreciated !!
My second step was to refactor the variable names to have them based on English, to finish the dependency on Italian for future contributors. Should it be done here while you are still available?
In both cases, take your time and I'll apply the suggestions this weekend.
Thanks for the heads up! In fact the suggestions added were all applied, I was waiting for a return for the rest of the review from @rmarzocchi84, but it didn't came through yet.
I still have the question of "do we try to refactor Italian variable names" in the scope of this PR to help keep the addon maintainable while the origin author is still accessible?
The draft status was to not make it ready to merge, since we were waiting for a response.
@lucadelu I was wondering if you would mind helping out with the italian here. Its one of my first PRs two years ago, and never got to finish it up yet.
Minor fixes in translation. I still have problems understanding L385 and the word stramazzo. I did not check the html file as I am not familiar with the topic.
Is stramazzo from https://it.m.wikipedia.org/wiki/Stramazzo the same as spillway from https://en.m.wikipedia.org/wiki/Spillway?
Html had way less changes, it was already in English.
Sorry, it's quite hard to review now, since the changes started before the code was formatted, and it was really hard to solve the conflicts (I merged in several passes since trying to merge from the current grass8 branch was too off)
@lucadelu I was wondering if you would mind helping out with the italian here. Its one of my first PRs two years ago, and never got to finish it up yet.
@echoix I checked the file and looks good to me, I have no idea about translation of stramazzo because I don't really know what is it in Italian too. Maybe @rmarzocchi84 or @massimiliano-cannata can help here
Hi there, Stramazzo in English is spillway, or weir
Maxi
Il dom 31 dic 2023, 09:17 Luca Delucchi @.***> ha scritto:
@lucadelu https://github.com/lucadelu I was wondering if you would mind helping out with the italian here. Its one of my first PRs two years ago, and never got to finish it up yet.
@echoix https://github.com/echoix I checked the file and looks good to me, I have no idea about translation of stramazzo because I don't really know what is it in Italian too. Maybe @rmarzocchi84 https://github.com/rmarzocchi84 or @massimiliano-cannata https://github.com/massimiliano-cannata can help here
— Reply to this email directly, view it on GitHub https://github.com/OSGeo/grass-addons/pull/683#issuecomment-1872838037, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADC2FTAHTUZIBZJFEOKIHXTYMENR7AVCNFSM5MSGRRPKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBXGI4DGOBQGM3Q . You are receiving this because you were mentioned.Message ID: @.***>
