gdal icon indicating copy to clipboard operation
gdal copied to clipboard
verified publisher icon OSGeo

PDF: fix build against PoDoFo with MSYS2 UCRT64 and CLANG64 environments

Open rouault opened this issue 1 year ago • 4 comments

Fixes #9976

rouault avatar May 22 '24 17:05 rouault

Coverage Status

coverage: 69.131%. remained the same when pulling 5f92903c15e89580caace585015f10566ea2bca5 on rouault:fix_9976 into 77031d722bb5ba5bde1e94c64b0da0bed9e7229c on OSGeo:master.

coveralls avatar May 22 '24 18:05 coveralls

It doesn't fix the issue, gdal_pdal.h is included first other heaters will redefine GetObject.

MehdiChinoune avatar May 23 '24 06:05 MehdiChinoune

It doesn't fix the issue

well, I did test it successfully locally on UCRT64 config

gdal_pdal.h is included first other heaters will redefine GetObject.

no, since we import windows.h, it won't be re-imported afterwards

rouault avatar May 23 '24 11:05 rouault

Yes, It works. I made a mistake when I tested it.

MehdiChinoune avatar May 23 '24 12:05 MehdiChinoune