gdal icon indicating copy to clipboard operation
gdal copied to clipboard

DODS/OPeNDAP Driver Removal... Please don't

Open vtdrfuka opened this issue 3 years ago • 10 comments

Just opening the ticket to request that the DODS driver remains in the mix. We have dependencies on this driver in several CRAN packages and python libraries.

DODS/OPeNDAP Driver short name: DODS

Driver is considered for removal in GDAL 3.5. You are invited to convert any dataset in that format to another more common one. If you need this driver in future GDAL versions, create a ticket at https://github.com/OSGeo/gdal (look first for an existing one first) to explain how critical it is for you (but the GDAL project may still remove it). T

vtdrfuka avatar Jan 26 '22 01:01 vtdrfuka

Which driver do you use: the raster one or the vector one ?

One issue we have is that our unit tests (https://github.com/OSGeo/gdal/blob/master/autotest/ogr/ogr_dods.py and https://github.com/OSGeo/gdal/blob/master/autotest/gdrivers/dods.py) don't work anymore due to test servers used initially not being available, and we (at least I) have no idea of how to test that driver and if it still works (the base assumption is that untested code is broken code). Are there public DODS servers somewhere ? Do you or someone else would volunteer to take over maintenance of those drivers ? At least bringing back the unit tests. Another annoyance of the raster DODS driver is that it takes directly a URL, which conflicts with the generic HTTP driver. A "DODS:" prefix should be required for dataset names.

rouault avatar Jan 26 '22 11:01 rouault

Call for action to the mailing list audience: https://lists.osgeo.org/pipermail/gdal-dev/2022-January/thread.html#55348

rouault avatar Jan 27 '22 15:01 rouault

Could the code be moved to the CRAN driver? If it is the only known user, seems possible.

bradh avatar Jan 27 '22 21:01 bradh

@vtdrfuka Please provide feedback regarding the questions posted in this ticket

rouault avatar Feb 01 '22 15:02 rouault

Let me review the test that is failing, as possibly it is just an outdated link. If this is the cause of the removal, it might be within my capability to get it to pass again! I will review a few options and test, with a response within a week; possibly linking the test to the OPeNDAP active development server which has been alive for quite some time.

Also, Thank You for tagging me, for some reason the replies were hidden in my inbox!

vtdrfuka avatar Feb 01 '22 15:02 vtdrfuka

@vtdrfuka - please share your example sources, perhaps it's better done with NetCDF itself (I haven't used DODS via GDAL for a long time, but NetCDF generally works with URLs in GDAL - and often I disable the DODS driver, or use /vsicurl or NetCDF: to avoid conflation - perhaps we can find alternatives along those lines for you)

mdsumner avatar Feb 16 '22 01:02 mdsumner

@vtdrfuka can you provide some feedback ? Otherwise the driver will be removed as planned

rouault avatar Mar 21 '22 19:03 rouault

Pull request removing the DODS drivers: https://github.com/OSGeo/gdal/pull/5666

rouault avatar May 04 '22 10:05 rouault

thanks @rouault !

mdsumner avatar Aug 05 '22 23:08 mdsumner

Why reopening ?

rouault avatar Aug 06 '22 06:08 rouault

Hmm, I can't recall doing this -- must have been an errant click!

nyalldawson avatar Aug 14 '22 03:08 nyalldawson