gdal icon indicating copy to clipboard operation
gdal copied to clipboard

PDFium since chromium/6618 has renamed headers

Open dotysan opened this issue 1 year ago • 1 comments

What is the bug?

For example in here core/fxge/agg/fx_agg_driver.h was renamed to core/fxge/agg/cfx_agg_devicedriver.h.

But gdal is still looking for the old file.

Steps to reproduce the issue

Run cmake -DGDAL_USE_PDFIUM=ON against any build after that change.

Versions and provenance

master

Additional context

No response

dotysan avatar Aug 24 '24 21:08 dotysan

Thanks!

dotysan avatar Aug 25 '24 22:08 dotysan

@rouault I'm hitting this build error when standing in docker/ on latest master and running ubuntu-full/build.sh --release --gdal v3.9.2 --proj master --platform linux/amd64 --tag 3.9.2. I don't think it's my computer/environment, I can build the small image just fine with the same command. Does the fix need to be backported into 3.9.3 as well?

pjonsson avatar Oct 04 '24 14:10 pjonsson

The GDAL 3.9 branch must be built against https://github.com/rouault/pdfium_build_gdal_3_9/ If you want to build it against https://github.com/rouault/pdfium_build_gdal_3_10, you'll have to backport changes in the PDF driver itself, but I won't do that myself

rouault avatar Oct 04 '24 14:10 rouault