gdal icon indicating copy to clipboard operation
gdal copied to clipboard

Initial implementation of float16 support

Open eschnett opened this issue 1 year ago • 4 comments

This implements support for the float16 datatype as proposed in https://github.com/OSGeo/gdal/pull/10146.

eschnett avatar Jun 30 '24 17:06 eschnett

I am planning to use #ifdef SIZEOF__FLOAT16 to check whether _Float16 is available. Would you prefer a different mechanism?

eschnett avatar Jul 09 '24 18:07 eschnett

I am planning to use #ifdef SIZEOF__FLOAT16 to check whether _Float16 is available.

that sounds reasonable. We should make sure that this is set in cmake/template/cpl_config.h.in so that code like out-of-tree drivers has also access to that define when building against GDAL headers

rouault avatar Jul 09 '24 18:07 rouault

Should GetSrcVal in pixelfunctions.cpp return 0 for float16, or report an error if unsupported?

eschnett avatar Jul 09 '24 19:07 eschnett

The GDAL project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 28 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular link to any issues which this pull request fixes

  • that you have written unit tests where possible In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request. If there is no further activity on this pull request, it will be closed in 2 weeks.

github-actions[bot] avatar Aug 27 '24 02:08 github-actions[bot]

While we hate to see this happen, this PR has been automatically closed because it has not had any activity in the last 6 weeks. If this pull request should be reconsidered, please follow the guidelines in the previous comment and reopen this pull request. Or, if you have any further questions, just ask! We love to help, and if there's anything the GDAL project can do to help push this PR forward please let us know how we can assist.

github-actions[bot] avatar Sep 10 '24 02:09 github-actions[bot]