Add a new function Set-SetupCompleteInitialize

[skyblaster]

Move the core functionality of Set-SetupCompleteCreateStart to a new Set-SetupCompleteInitialize function for more consistency and modularization.

• Responsible for ensuring that the SetupComplete folder, bat, and ps1 files are created
• Add as a check to all Set-SetupComplete functions, so that they can create the files independently of the main task sequence.
• This fixed some functions that would produce a 'scripts' file instead of a folder
• Update all Set-SetupComplete functions to remove Write-Output "$PSFilePath - Not Found" else statements. If the intention is to append SetupComplete.ps1, we must make it so.

[gwblok]

This all looks good. Unsure when I'll get a chance to test this all, but initial glance, it all makes sense. I'll try to get around to testing it soon.

I'm assuming you've already tested most of those features and confirmed it does make the setup complete files, and everything is working as expected?

[skyblaster]

I'm assuming you've already tested most of those features and confirmed it does make the setup complete files, and everything is working as expected?

Yes. Since they are easy to validate on a host system, I've tested them all.

I don't use many of these features, but I've tested one run through in a VM with no ill effects using the standard options in Start-OSDCloudGUI.

I see I missed adding the following files. But perhaps they are autogenerated? Docs\Set-SetupCompleteInitialize.md en-US\OSD-help.xml

[AkosBakos]

@OSDeploy any thoughts on the last question from @skyblaster regarding these files: Docs\Set-SetupCompleteInitialize.md en-US\OSD-help.xml

[gwblok]

Pretty sure they are auto generated. Which is why I need to do a better job in my contributions to format the code properly.

On Mon, Sep 30, 2024, 4:20 PM Ákos Bakos @.***> wrote:

@OSDeploy https://github.com/OSDeploy any thoughts on the last question from @skyblaster https://github.com/skyblaster regarding these files: Docs\Set-SetupCompleteInitialize.md en-US\OSD-help.xml

— Reply to this email directly, view it on GitHub https://github.com/OSDeploy/OSD/pull/177#issuecomment-2384164384, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGIX45IFLLLOOWYUOTSGUR3ZZG6CHAVCNFSM6AAAAABPAKIRM6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBUGE3DIMZYGQ . You are receiving this because you were assigned.Message ID: @.***>

[OSDeploy]

Set-SetupCompleteInitialize.md en-US\OSD-help.xml

Yes they are auto-generated. I'll address.

[gwblok]

Not saying this is a bad idea, just not something I want to tackle right now.
Backlog the idea for future enhancement