OSD icon indicating copy to clipboard operation
OSD copied to clipboard

Block-NoInternet function is providing false results

Open gwblok opened this issue 10 months ago • 3 comments

Test-WebConnection -Uri 'microsoft.com' is reporting false when it should be true. Unsure what changed.

image

This has broken some functionality in OSD that downloads things from the internet.

gwblok avatar Mar 27 '24 18:03 gwblok

I'm updating 'microsoft.com' to 'google.com' as a quick fix... plan to incorporate a better plan to loop through URLs for tests.

gwblok avatar Mar 27 '24 18:03 gwblok

Fixed in latest module. 24.3.27.1

Still plans to make more robust.

gwblok avatar Mar 27 '24 21:03 gwblok

Added a check for 4 different sites, it will check in order, the first one that responds back as TRUE, it's all good. If it fails, it continues through all 4 before it says it's "FALSE" This does add a little delay if there is no interent, but hey, if there is no interent when this function is called, there are bigger issues.

$TestURLs = @('google.com','github.com','nvidia.com','apple.com')

@OSDeploy, hoping you can double check my code logic on that one.

gwblok avatar Apr 03 '24 18:04 gwblok

This is now live, closing issue

gwblok avatar Apr 12 '24 01:04 gwblok